Improve interrupt handing in mb88xx #11868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the flag IF as listed in the datasheet.
The datasheet doesn't mention this, but is pretty light on interrupt details. It does say "nesting level" is "single level" on page 1-26, which could be this behavior. The previous behavior to always clear the int enable bit seems to be wrong, so remove it.
|
Can some people give this a spin? This is an area that’s been fraught with issues over the years. |
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
…cleared by RTI. (mamedev#11868) Suppressing nested interrupts appears to fix issues in Arabian (MT03916 and MT08436). Also renamed m_nf to m_if to match the datasheet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with the interrupt handler a little better, and fixes Arabian bugs caused by mb88xx bugs.
I tested it with the other games that use that chip, and didn't see any regressions. Most importantly, none in bosco sound. The 54xx in bosco seem especially sensitive to interrupt races, causing the pitch of shots to be wrong.
Should fix https://mametesters.org/view.php?id=8436 & https://mametesters.org/view.php?id=3916