Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkspirit.cpp - doesn't use tilemaps, uses a spritelist. remove tilemaps, hook up preliminary list #11896

Merged
merged 9 commits into from Jan 7, 2024

Conversation

mamehaze
Copy link
Contributor

@mamehaze mamehaze commented Jan 3, 2024

No description provided.

@mamehaze
Copy link
Contributor Author

mamehaze commented Jan 3, 2024

as per @angelosa comment in previous PR, the list is meant to be copied with a DMA, but for now just process it where it is (it'll be a simple case of changing a constant once it's in the correct location)

this removes the tilemaps, as they don't exist, and draws the previously shown layers with the correct colours. no attempt has been made to draw more complex objects from the list yet.

@mamehaze
Copy link
Contributor Author

mamehaze commented Jan 3, 2024

0006
0007
0008
0009

@mamehaze
Copy link
Contributor Author

mamehaze commented Jan 3, 2024

meme

@mamehaze
Copy link
Contributor Author

mamehaze commented Jan 3, 2024

anyway, basically I'm done with this for now as I have other things to look at.

the x/y sprite sizes need narrowing down properly, and the purpose of the 2bpp font it uploads needs figuring out (maybe there's another fixed tilemap layer, possibly not used here?)

otherwise, it's in a much better state than it was before.

@mamehaze
Copy link
Contributor Author

mamehaze commented Jan 3, 2024

pkspirit_1
pkspirit_2
pkspirit_3
pkspirit_4

of note the 'hold' sprite is currently wrong.

also there's no credit display, which is why I wonder if that 2bpp font is for a fixed layer of some kind (unless it's currently just positioned off-screen)

src/mame/taito/pkspirit.cpp Outdated Show resolved Hide resolved
@mamehaze
Copy link
Contributor Author

mamehaze commented Jan 4, 2024

The final changes I've made fix the HOLD display, and paytable display (draw red sprite behind numbers, not over) although there is still a small glitch on the reel for the 'with reel' double up type. Could be there's a proper priority scheme I've missed, but with only a single game on this hardware it's difficult to draw solid conclusions.
0033
0051

@rb6502 rb6502 merged commit 9f26def into mamedev:master Jan 7, 2024
5 checks passed
einstein95 pushed a commit to einstein95/mame that referenced this pull request Mar 2, 2024
…ps, hook up preliminary list (mamedev#11896)

---------
Co-authored-by: David Haywood <hazemamewip@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants