Add 4 74-series chips to netlist devices #11921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Jan 17, 2024
Comment on lines
+3357
to
+3375
| TT_HEAD("C,B,A,G,D0,D1,D2,D3,D4,D5,D6,D7|Y,W") | ||
| TT_LINE( "X,X,X,1,X,X,X,X,X,X,X,X|0,1|38,30") | ||
| TT_LINE( "0,0,0,0,1,X,X,X,X,X,X,X|1,0|38,30") | ||
| TT_LINE( "0,0,0,0,0,X,X,X,X,X,X,X|0,1|38,30") | ||
| TT_LINE( "0,0,1,0,X,1,X,X,X,X,X,X|1,0|38,30") | ||
| TT_LINE( "0,0,1,0,X,0,X,X,X,X,X,X|0,1|38,30") | ||
| TT_LINE( "0,1,0,0,X,X,1,X,X,X,X,X|1,0|38,30") | ||
| TT_LINE( "0,1,0,0,X,X,0,X,X,X,X,X|0,1|38,30") | ||
| TT_LINE( "0,1,1,0,X,X,X,1,X,X,X,X|1,0|38,30") | ||
| TT_LINE( "0,1,1,0,X,X,X,0,X,X,X,X|0,1|38,30") | ||
| TT_LINE( "1,0,0,0,X,X,X,X,1,X,X,X|1,0|38,30") | ||
| TT_LINE( "1,0,0,0,X,X,X,X,0,X,X,X|0,1|38,30") | ||
| TT_LINE( "1,0,1,0,X,X,X,X,X,1,X,X|1,0|38,30") | ||
| TT_LINE( "1,0,1,0,X,X,X,X,X,0,X,X|0,1|38,30") | ||
| TT_LINE( "1,1,0,0,X,X,X,X,X,X,1,X|1,0|38,30") | ||
| TT_LINE( "1,1,0,0,X,X,X,X,X,X,0,X|0,1|38,30") | ||
| TT_LINE( "1,1,1,0,X,X,X,X,X,X,X,1|1,0|38,30") | ||
| TT_LINE( "1,1,1,0,X,X,X,X,X,X,X,0|0,1|38,30") | ||
| TT_FAMILY("74XX") |
There was a problem hiding this comment.
Why are you using worst-case propagation delays for the 74LS version on this chip?
Comment on lines
+3475
to
+3493
| TT_HEAD("OE,A1,A2,A3,A4|Y1,Y2,Y3,Y4") | ||
| TT_LINE("1,X,X,X,X|0,0,0,0|45") | ||
| TT_LINE("0,0,0,0,0|1,1,1,1|45") | ||
| TT_LINE("0,0,0,0,1|1,1,1,0|45") | ||
| TT_LINE("0,0,0,1,0|1,1,0,1|45") | ||
| TT_LINE("0,0,0,1,1|1,1,0,0|45") | ||
| TT_LINE("0,0,1,0,0|1,0,1,1|45") | ||
| TT_LINE("0,0,1,0,1|1,0,1,0|45") | ||
| TT_LINE("0,0,1,1,0|1,0,0,1|45") | ||
| TT_LINE("0,0,1,1,1|1,0,0,0|45") | ||
| TT_LINE("0,1,0,0,0|0,1,1,1|45") | ||
| TT_LINE("0,1,0,0,1|0,1,1,0|45") | ||
| TT_LINE("0,1,0,1,0|0,1,0,1|45") | ||
| TT_LINE("0,1,0,1,1|0,1,0,0|45") | ||
| TT_LINE("0,1,1,0,0|0,0,1,1|45") | ||
| TT_LINE("0,1,1,0,1|0,0,1,0|45") | ||
| TT_LINE("0,1,1,1,0|0,0,0,1|45") | ||
| TT_LINE("0,1,1,1,1|0,0,0,0|45") | ||
| TT_FAMILY("74XX") |
There was a problem hiding this comment.
These propagation delays seem unreasonably long. Typical propagation delays are below 10ns for high-to-low and vice versa, and below 25ns to exit high-impedance state. Worst case for entering high-impedance state is quoted at 35ns. The propagation delay of 45ns here is worse than the worst case in the datasheet for any transition.
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
for use with the netlist system.
They will be needed to support Monaco GP, which i'm still working on.