Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinclair/sprinter.cpp: fix INT; add cdrom, dvdrom #11933

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Conversation

holub
Copy link
Contributor

@holub holub commented Jan 14, 2024

No description provided.

@rb6502 rb6502 merged commit 0f0b802 into mamedev:master Jan 14, 2024
5 checks passed
Comment on lines -1442 to +1445
device.option_add("cdrom", ATAPI_CDROM);
device.option_add("cdrom", ATAPI_FIXED_CDROM);
device.option_add("dvdrom", ATAPI_FIXED_DVDROM);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using the fixed media devices here? They’re intended for systems where the optical drive is not accessible to the user and hence media can’t be changed (e.g. an arcade game that uses CD-ROM media for storage, with the drive inside the cabinet where the player can’t access it).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we tested, the base one didn't behave properly. Software in Sprinter which access CDROM only works with this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-5192843773191772465_121.jpg

From my notes: Base doesn't run if (m_media_change) {}
Which after your comment suspected to be vice versa.

einstein95 pushed a commit to einstein95/mame that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants