sinclair/sprinter.cpp: fix INT; add cdrom, dvdrom #11933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Jan 15, 2024
Comment on lines
-1442
to
+1445
| device.option_add("cdrom", ATAPI_CDROM); | ||
| device.option_add("cdrom", ATAPI_FIXED_CDROM); | ||
| device.option_add("dvdrom", ATAPI_FIXED_DVDROM); |
There was a problem hiding this comment.
Why are you using the fixed media devices here? They’re intended for systems where the optical drive is not accessible to the user and hence media can’t be changed (e.g. an arcade game that uses CD-ROM media for storage, with the drive inside the cabinet where the player can’t access it).
There was a problem hiding this comment.
When we tested, the base one didn't behave properly. Software in Sprinter which access CDROM only works with this one.
There was a problem hiding this comment.
From my notes: Base doesn't run if (m_media_change) {}
Which after your comment suspected to be vice versa.
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.