handheld/hh_ht11xx.cpp: Add support for Brick Game

[mamehaze]

new WORKING machines

Block Game & Echo Key [azya52, David Haywood]

[cuavas]

Please give your pull requests descriptive titles. You currently haven several with no indication of what systems, or what kinds of systems, they add.

[happppp]

Do you want "ga888" to be the shortname, or something that resembles "Block Game & Echo Key" more?

[mamehaze]

the names on these things tend to be so generic I don't think it really matters. ga888 just seems more concise in this case than trying to fit a bunch of generic descriptor words there.

[ICEknigh7]

Also, "GA888" seems to be displayed quite prominently on the unit.

[mamehaze]

I do wonder how the flashing blocks are meant to work though, they seem different in each game mode, but I'm finding the behavior in the first mode to be nonsensical. Could be a dumping issue given these are visual decaps (or a CPU bug if it makes more sense in the other emulator, but I haven't tested it there)

(or I could just be being stupid and not understanding some simple game logic)

There's also the 'up' button, which isn't marked as anything and doesn't seem to be read (is it even connected?)

[mamehaze]

ok, azya52 pointed out that the rules for the flashing blocks are here
https://datasheet.datasheetarchive.com/originals/library/Datasheet-036/DSA0020063.pdf

so it has basically nothing to do with the individual blocks, just each shape has a different special meaning. no wonder I couldn't figured it out.

[mamehaze]

likewise I've got another MameDev member saying this looks fine to them, but is also afraid to merge it because you might consider it a strike against them in terms of their direct access rights if there is something minor you're unhappy with.

[etabeta78]

Have you considered the fact that several contributors do no raise all such drama, when asked to modify their submissions, sometimes quite heavily? Also, do you plan to transform each of you pull request into a fight? 🤔 Because I do not think it helps the project in any way, nor it helps you in proving a point against Vas My 2c

…

On Monday, January 22, 2024, mamehaze ***@***.***> wrote: likewise I've got another MameDev member saying this looks fine to them, but is also *afraid* to merge it because they might consider it a strike against them in terms of their direct access rights if there is something minor you're unhappy with. — Reply to this email directly, view it on GitHub <#11942 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACGSVPG34YIYREO3FUECJO3YP2OO3AVCNFSM6AAAAABB6T7M7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUGQ3TENRTGI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[mamehaze]

I have modified my PRs as requested.

Others, on the team agree, these demands were unnecessary.

Either way, it now meets those demands, I submit, it can be included.

There was nothing controversial here that couldn't have been dealt with post-merge.

That nobody will merge it until Vas decides to merge it speaks volumes. Not even sure why I'm bothering to reply.

Please update your slot / softlist stuff up to Vas standard, and if you can't see how, imagine how far behind the project would be had it not gone in. A lot of his criticism is tearing apart patterns you introduced which I'm learning from and duplicating. (It's fine, it served a purpose, it still does, I appreciate it being there)