Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine/s2350.cpp: Add new AMI S2350 USRT, prep for Heath hard-sectored support #11959

Merged
merged 4 commits into from Jan 24, 2024

Conversation

mgarlanger
Copy link
Contributor

Adds the AMI's USRT S2350 USRT needed for the Heath hard-sectored disk controller.

This is prep work for supporting the H-88-1 hard-sectored controller for the Heath H89.

src/devices/machine/s2350.cpp Outdated Show resolved Hide resolved
src/devices/machine/s2350.cpp Outdated Show resolved Hide resolved
src/devices/machine/s2350.h Outdated Show resolved Hide resolved
src/devices/machine/s2350.h Outdated Show resolved Hide resolved
src/devices/machine/s2350.h Outdated Show resolved Hide resolved
Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make this always log (e.g. with logerror) when the host system uses an unimplemented, like configuring a smaller word size or enabling parity? It helps greatly when hooking a device up to a system if you get a notification when you run into a known limitation.

Comment on lines 251 to 256
if (!machine().side_effects_disabled()) {
set_fill_char_transmitted(false);
set_receiver_overrun(false);
set_receiver_parity_error(false);
set_sync_character_received(false);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K&R formatting snuck in (rest of the file is Allman).

@mgarlanger
Copy link
Contributor Author

Can you please make this always log (e.g. with logerror) when the host system uses an unimplemented, like configuring a smaller word size or enabling parity? It helps greatly when hooking a device up to a system if you get a notification when you run into a known limitation.

The configuration for things like data size, parity on/off, even/odd, is done by setting the chip's pins high/low:

NDB1/NDB2        39-40       Number Data Bits
NPB                3         No Parity Bit
POE                4         Parity Odd/Even

I didn't define any methods to allow those to be changed. So it is basically hard-coded as NDB1 and NDB2 are set to high (8 bits), NPB is set to high (no parity), and POE is a don't care. If someone wants to use this chip and needs a different configuration, they would need to implement it.

@cuavas
Copy link
Member

cuavas commented Jan 24, 2024

Can you please make this always log (e.g. with logerror) when the host system uses an unimplemented, like configuring a smaller word size or enabling parity? It helps greatly when hooking a device up to a system if you get a notification when you run into a known limitation.

The configuration for things like data size, parity on/off, even/odd, is done by setting the chip's pins high/low:

NDB1/NDB2        39-40       Number Data Bits
NPB                3         No Parity Bit
POE                4         Parity Odd/Even

I didn't define any methods to allow those to be changed. So it is basically hard-coded as NDB1 and NDB2 are set to high (8 bits), NPB is set to high (no parity), and POE is a don't care. If someone wants to use this chip and needs a different configuration, they would need to implement it.

Ah, so it's not controlled by register writes. That's OK then.

@cuavas cuavas merged commit 035d498 into mamedev:master Jan 24, 2024
5 checks passed
MooglyGuy pushed a commit to MooglyGuy/mame that referenced this pull request Jan 28, 2024
Frame format configuration is not implemented yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants