New working machines (Casio CZ-230S and SZ-1) #11969
Conversation
---------- Casio CZ-230S [BCM, =CO=Windler, Devin Acker] Casio SZ-1 [BCM, Devin Acker]
devinacker
changed the title
src/devices/sound/upd934g.cpp
Outdated
| case 2: // muted | ||
| case 3: // accented | ||
| { | ||
| const u8 ch = (data & 3) ^ 2; // effective order seems to be "2, 3, 0, 1" |
There was a problem hiding this comment.
Why the ^ 2? I mean, all outputs go to the same speaker anyway, so the order shouldn't matter.
There was a problem hiding this comment.
I did that mostly so that the output ordering would still be correct for the RZ-1, since that does have the individual volume control and line outputs for each sample.
src/devices/video/mn1252.h
Outdated
| u8 m_data; | ||
| u8 m_first_nibble; | ||
| u8 m_nibble_count; | ||
| int m_ce, m_std; |
There was a problem hiding this comment.
Members that need to be included in save states should use explicitly sized integers for portability. Please use u8 or something for m_ce and m_std.
src/devices/video/mn1252.cpp
Outdated
| { | ||
| m_data = (data & 0xf); | ||
| } |
There was a problem hiding this comment.
Not very important, but the parentheses here don’t really make the expression clearer.
src/mame/casio/cz230s.cpp
Outdated
| #include "emu.h" | ||
|
|
||
| #include "ra3.h" | ||
| #include "bus/midi/midiinport.h" | ||
| #include "bus/midi/midioutport.h" | ||
| #include "cpu/upd7810/upd7811.h" | ||
| #include "imagedev/cassette.h" | ||
| #include "machine/clock.h" | ||
| #include "machine/nvram.h" | ||
| #include "sound/beep.h" | ||
| #include "sound/upd933.h" | ||
| #include "sound/upd934g.h" | ||
| #include "video/mn1252.h" | ||
|
|
||
| #include "screen.h" | ||
| #include "speaker.h" |
There was a problem hiding this comment.
Can you put a blank line after #include "ra3.h" to visually separate local project headers from the src/devices headers?
src/mame/casio/cz230s.cpp
Outdated
| void cz230s_state::render_w(int state) | ||
| { | ||
| if(!state) | ||
| return; | ||
|
|
||
| for (int digit = 0; digit < 6; digit++) |
There was a problem hiding this comment.
Another minor formatting thing – this if statement is missing the space before the opening parenthesis of its control expression.
src/mame/casio/cz230s.cpp
Outdated
| auto& screen = SCREEN(config, "screen", SCREEN_TYPE_SVG); | ||
| screen.set_refresh_hz(60); |
There was a problem hiding this comment.
This right-associative unary & is on the left of the space, unlike the other ones which are on the right of the space.
* cpu/upd7810: Added support for internal RAM. * sound/upd934g.cpp: Corrected channel mapping for play sample command. * video/mn1252.cpp: Added Panasonic MN1252 LCD controller emulation. * casio/ra3.cpp: Added RA-5 8 KiB RAM cartridge. New working systems ---------- Casio CZ-230S [BCM, =CO=Windler, Devin Acker] Casio SZ-1 [BCM, Devin Acker]
Casio CZ-230S [BCM, =CO=Windler, Devin Acker]
Casio SZ-1 [BCM, Devin Acker]
This commit also: