Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memarray.cpp: Fix use of mismatched endianness macros #11985

Merged
merged 1 commit into from Jan 29, 2024

Conversation

amameuser
Copy link
Contributor

@amameuser amameuser commented Jan 29, 2024

Fixes the little-endian functions read8_from_64le and write8_to_64le using the big-endian BYTE8_XOR_BE macro instead of the little-endian BYTE8_XOR_LE macro.

@cuavas cuavas merged commit a83d26b into mamedev:master Jan 29, 2024
@cuavas
Copy link
Member

cuavas commented Jan 29, 2024

For what it’s worth, the memory_array class isn’t recommended for use in new code, but still better to have these lurking things fixed.

@amameuser amameuser deleted the misc_fixes_memarray branch January 31, 2024 11:32
stonedDiscord pushed a commit to stonedDiscord/mame that referenced this pull request Apr 8, 2024
…amedev#11985)

Apparent copy/paste error was causing big Endian semantics to be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants