cpu/t11: add basic support for K1801VM1 #11995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Feb 7, 2024
| OP(op_0000), OP(halt), OP(illegal), OP(illegal), OP(illegal), OP(illegal), OP(illegal), OP(illegal), | ||
| OP(op_0000), OP(op_0001), OP(illegal), OP(illegal), OP(illegal), OP(illegal), OP(illegal), OP(illegal), |
There was a problem hiding this comment.
Won’t this change behaviour for all T11 family CPU devices now? As far as I can tell, this changes what was previously halt to an illegal instruction for everything besides the K1801VM1. Wouldn’t you need to also make t11_device::halt(uint16_t op) call t11_device::halt(uint16_t op) if the CPU is not a K1801VM1 to preserve current behaviour for existing CPU types?
There was a problem hiding this comment.
T11 user's manual (page B-7) lists these opcodes as reserved and not as HALT, and I believe other processors in the pdp-11 family treat them likewise.
There was a problem hiding this comment.
Do you know why it was treating it as halt in the first place?
Mokona
pushed a commit
to Mokona/mame
that referenced
this pull request
Feb 28, 2024
stonedDiscord
pushed a commit
to stonedDiscord/mame
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.