nec/pce.cpp, nec/pce_cd.cpp: Various updates #11999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cam900
commented
Feb 2, 2024
•
cam900
commented
- Use device_mixer_interface rather than using hard-coded speaker tag
- Reduce defines
- Remove outdated comments
- Use lowercase hexadecimal values
- Remove nec/pce_m.cpp, Move pce_m.cpp codes into nec/pce.cpp
- Use device_mixer_interface rather than using hard-coded speaker tag - Reduce defines - Remove nec/pce_m.cpp, Move pce_m.cpp codes into nec/pce.cpp
angelosa
reviewed
Feb 2, 2024
|
What’s the motivation for moving it into src/devices/machine? Is it used for anything besides the PC-Engine? |
|
File is currently a mixup of PC8801-30 drive, the specific (and opaque) PC Engine SCSI controller and the rest of the expansion unit bus & i/f. afaik PC8801-31 SCSI isn't much different beyond relying on SEL line alone (and doing the rest internally), a preliminary core i/f (without the controller part, maybe at ID 7): Bottom line: not convinced about the move either, it's essentially a NEC i/f that can stay in |
…Remove unused macro
cam900
changed the title
angelosa
approved these changes
Feb 13, 2024
Mokona
pushed a commit
to Mokona/mame
that referenced
this pull request
Feb 28, 2024
* nec/pce_cd.cpp: Use device_mixer_interface rather than using hard-coded speaker tags. * Merged nec/pce_m.cpp into nec/pce.cpp. * Reduced preprocessor macros, removed outdated comments, changed heaxadecimal digits to lowercase.
stonedDiscord
pushed a commit
to stonedDiscord/mame
that referenced
this pull request
Apr 8, 2024
* nec/pce_cd.cpp: Use device_mixer_interface rather than using hard-coded speaker tags. * Merged nec/pce_m.cpp into nec/pce.cpp. * Reduced preprocessor macros, removed outdated comments, changed heaxadecimal digits to lowercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.