Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process all new ROM dumps sent by Team Europe and Sean Riddle [David Haywood] #12004

Merged
merged 28 commits into from
Mar 20, 2024

Conversation

mamehaze
Copy link
Contributor

@mamehaze mamehaze commented Feb 3, 2024

new NOT WORKING machines

Interactive M.A.G. Motion Activated Gear: Toy Story and Beyond! Buzz Lightyear Galactic Adventure [David Haywood, Sean Riddle]
Interactive M.A.G. Motion Activated Gear: The Batman - Villains of Gotham City [David Haywood, Sean Riddle]
Interactive M.A.G. Motion Activated Gear: Spider-Man - Triple Threat [David Haywood, TeamEurope]
Who Wants to Be a Millionaire? (Play Vision, Plug and Play, UK, 8-bit version) [David Haywood, TeamEurope]
Excite Tennis (Japan) [David Haywood, TeamEurope]
Sudoku: Do You Sudoku? [David Haywood, TeamEurope]

new NOT WORKING clones

Fun 2 Learn Smart Fit Park (France) [David Haywood, TeamEurope]

--------------
Interactive M.A.G. Motion Action Gear: Toy Story and Beyond! Buzz Lightyear Galactic Adventure [Sean Riddle]
@mamehaze
Copy link
Contributor Author

mamehaze commented Feb 3, 2024

this used an unusual 'square' ROM glob, which took a lot of figuring out the pin-out of for Sean.

current ROM data should be in the correct order.

there are likely MCUs in the wearable parts of this though, as they can make sounds etc. without the main unit being turned on (number of parts involved is unknown)

src/mame/tvgames/elan_eu3a14.cpp Outdated Show resolved Hide resolved
src/mame/tvgames/elan_eu3a14vid.cpp Outdated Show resolved Hide resolved
@mamehaze mamehaze changed the title new NOT WORKING machines new NOT WORKING machines - Motion Activated Gear systems Mar 1, 2024
@mamehaze
Copy link
Contributor Author

mamehaze commented Mar 1, 2024

I'm not really sure this can move forward more until further games are dumped using the hardware type , the existing set are not providing what I would call definitive evidence, so I'm done with this for now.

------------
Fun 2 Learn Smart Fit Park (France) [David Haywood, TeamEurope]
@mamehaze mamehaze changed the title new NOT WORKING machines - Motion Activated Gear systems new NOT WORKING plug and play additions (MAG + Smart Fit Park France) Mar 6, 2024
@mamehaze
Copy link
Contributor Author

(as always, for the hi-kara user carts somebody with knowledge of Japanese should add the tracks to the xml)

@mamehaze mamehaze changed the title new NOT WORKING plug and play additions (MAG + Smart Fit Park France) new NOT WORKING plug and play additions (MAG + Smart Fit Park France + various Karaoke carts) Mar 15, 2024
@cuavas
Copy link
Member

cuavas commented Mar 18, 2024

Please split out the simple cartridge additions, and add photos and screenshots so that the titles and track lists can be sorted out before the stuff gets merged. If it isn’t done beforehand, it won’t get done, and it will just add to the generally poor state of software lists.

@mamehaze
Copy link
Contributor Author

mamehaze commented Mar 18, 2024

I'd rather not split things up as it's just extra churn, and the only way I can stay on top of the new dumps is by working with whatever open PR I have. I'll compromise and just remove all code outside of the set additions.

Photos were provided with the ROMs, but I'll put them here too anyway.

@cuavas
Copy link
Member

cuavas commented Mar 19, 2024

Your list of additions in the pull request description does not have credits for systems or software list item. You did this last month as well resulting in TeamEurope’s cartridge dumps almost being credited to xtrasmiley.

I’ve got the cartridge additions ready to commit locally. Who should be credited for each of the cartridge dumps?

@mamehaze
Copy link
Contributor Author

mamehaze commented Mar 19, 2024

The credits were originally there in the description, but I removed them in response to RB saying items couldn't have different credits in the same PR, as a result I requested that I simply be credited to resolve the issue. (Some of the MAG games were dumped by Sean and some were by Team Europe)

@mamehaze
Copy link
Contributor Author

I really wish the team would make up their fucking minds, because I just feel like I'm jumping through hoops only to have to jump backwards through them again here.

@mamehaze mamehaze closed this Mar 19, 2024
@mamehaze mamehaze deleted the 010224 branch March 19, 2024 21:24
@cuavas
Copy link
Member

cuavas commented Mar 19, 2024

You’re misrepresenting what @rb6502 – he said that putting additions from different contributor in a single pull request is liable to cause confusion if don’t make it very clear what came from each contributor.

@mamehaze
Copy link
Contributor Author

mamehaze commented Mar 19, 2024

Well every item was individually credited, correctly and clearly, at the point he complained, how else am I meant to interpret it?

@cuavas
Copy link
Member

cuavas commented Mar 19, 2024

I really wish the team would make up their fucking minds, because I just feel like I'm jumping through hoops only to have to jump backwards through them again here.

No you aren’t:

  • @rb6502 asked you not to mix additions from different contributors in the same pull request to avoid confusion. You’ve done that again.
  • I’ve asked you to provide images in pull requests for media where you can’t read the titles. You still won’t do it without being prompted.
  • I’ve asked you multiple times to use the wording for list headings in the whatsnew files. You still won’t do that (e.g here you haven’t even separated working and non-working software list additions).
  • You’ve been asked not to mix unrelated changes in the same pull request. You keep doing that.

Once again, I have all the cartridge additions ready to commit. Who did the each cartridge come from?

@cuavas
Copy link
Member

cuavas commented Mar 19, 2024

I really wish the team would make up their fucking minds, because I just feel like I'm jumping through hoops only to have to jump backwards through them again here.

You want to constantly accuse me of “rudeness” but you resort to swearing when asked for clarification. Do you fail to see the irony?

The request not to mix additions from different contributors is absolutely fucking ridiculous, the MAG stuff from Team Europe and Sean is in the same driver even. Seems like a new rule is being made up every week.

It isn’t a “rule”. @rb6502 requested that you not mix them because you weren’t making it clear what came from where, leading to confusion and things almost being credited to the wrong people. There’s less chance of that happening if the credits are the same for everything in a single PR.

@mamehaze
Copy link
Contributor Author

mamehaze commented Mar 19, 2024

As for where the cartridges came from, work it out yourself. I've no further inclination to help you. I'm done jumping through hoops.

EVERYTHING was correctly credited before RB asked me to change it. EVERYTHING was clear and if you don't fucking believe me there's the edit history to prove it.

I'm not even a rude person, but you drive me to this point with your pedantic obsessive bullshit which makes developing for MAME less of a fun task, and more one that damages my mental health so much it makes me want to find the nearest bridge to jump off.

This is a very simple PR full of very simple additions, it should not be a chore.

@cuavas
Copy link
Member

cuavas commented Mar 19, 2024

EVERYTHING was correctly credited before RB asked me to change it. EVERYTHING was clear and if you don't fucking believe me there's the edit history to prove it.

GitHub does not show edit history for comments or pull request descriptions. We get a notification when a pull request is opened or a comment is added. We do not get notifications when a pull request description or comment is edited.

The audit log shows the times when comments were edited. However it doesn’t show the content before/after the edit.

The only edits where content before/after is visible are edits to pull request and issue titles.

There is no way I can see the description of the pull request at the time you claim it had proper credits. Since it wasn’t there when you opened the pull request, it isn’t in the initial notification e-mail. There is no user-visible edit history.

@cuavas
Copy link
Member

cuavas commented Mar 19, 2024

Oh never mind, I found it. It’s hidden behind JavaScript on the page itself.

@mamehaze mamehaze reopened this Mar 19, 2024
@mamehaze mamehaze closed this Mar 19, 2024
@mamehaze mamehaze reopened this Mar 19, 2024
@mamehaze
Copy link
Contributor Author

The Softlist changes have been reverted.

@mamehaze
Copy link
Contributor Author

So now you've stolen the Software List parts of this, when it would have been easier to just merge the whole thing, what happens to the rest of it? Why is this simple case of adding some sets now such a nightmare?

Why is there so much needless bureaucracy here?

Who benefits from this?

@cuavas
Copy link
Member

cuavas commented Mar 19, 2024

You know, it would have been a lot easier if you’d just said, “all the cartridges were from me and TeamEurope” or something. You’re complaining about your workflow being interfered with, but at the same time going out of your way to make it difficult for everyone else.

@mamehaze
Copy link
Contributor Author

mamehaze commented Mar 19, 2024

I literally added the correct credits, and have been messed around. You're pulling apart simple PRs, needlessly. My mood would be better if you weren't making MAME such a fucking nightmare to work for.

Even now, rather than just merge the PR, you've forced me to deal with merge conflicts to get this PR mergable again. Added extra steps that don't need to be there.

This is just for the simple stuff. I've already retired from trying to make any actual progress in MAME, or cleaning anything up anywhere in MAME because of this. You're pushing to the point where I won't even bother trying to verify any of the new dumps either.

@mamehaze
Copy link
Contributor Author

and personally I'd consider blanking / ghosting me just because I didn't agree with your suggested changed before for over a month to be equally as rude as anything I've said. I've reverted those changes now because I'd only made them to make sure the ROMs were good in the first place (which I thought had value, but I guess I should have made less effort)

if you're not going to give developers the freedom to develop, then development will not happen. Micromanaging everything is not the way forward.

apparently you've done the same to that Sonic proto, just ghosted the PR, because you don't want to merge it.

absolutely shit project management.

@cuavas
Copy link
Member

cuavas commented Mar 19, 2024

So now you've stolen the Software List parts of this, when it would have been easier to just merge the whole thing, what happens to the rest of it? Why is this simple case of adding some sets now such a nightmare?

I “stole” the software list parts because I fixed the titles, added track lists for user cartrdiges, fixed the now-outdated comment about undumped main series e-kara cartridges, etc. I also separated working and non-working items in the commit message so I don’t have discrepancies to resolve there when sorting out the release notes.

You weren’t going to fix the titles or add track lists yourself. You don’t read Japanese, as you’re always so quick to remind us. If I provided you with the details in review comments to add to your branch, you’d just complain that it’s inconvenient for you.

If I edited the files on your PR branch, it would add to the the already-convoluted commit history, and it would still be mixed up with the other unrelated stuff.

No matter what I do you’re going to complain. At least this way the software list items go in cleanly, and it’s an software list-only change that doesn’t need to trigger macOS and Windows CI builds.

@cuavas cuavas closed this Mar 19, 2024
@cuavas cuavas reopened this Mar 19, 2024
@cuavas
Copy link
Member

cuavas commented Mar 19, 2024

apparently you've done the same to that Sonic proto, just ghosted the PR, because you don't want to merge it.

No, it’s another case of a person mixing unrelated things together, and repeatedly adding to it. Every time I go to try and salvage non-contentious parts from it, I find it’s changed again.

You seem to have this idea that if I haven’t actively commented on something in the last few days I’ve forgotten about it. That isn’t true.

@mamehaze
Copy link
Contributor Author

mamehaze commented Mar 19, 2024

The prototype isn't contentious.

Holding a personal grudge at the expense of preserving something, just because you don't like that it was hacked (and you won't be seeing an unhacked copy) is a critical failure of MAME's neutrality.

If you ignore a PR for near enough a year, yes, it will likely grow as related items are discovered and pushed, as you've created a bottleneck, broken somebody's workflow, and left things in a state where there will be merge conflicts that need to be fixed over and over again. This makes MAME look absolutely awful.

The fact that you brought up the same issue again with this PR when reminded about it, even if I said I preferred to not make the changes requested (thus ignoring developer preference) tells me you're going to just treat that one the same way, and will try and pull it apart still ignoring the Sonic addition, because you're that petty.

@ICEknigh7
Copy link
Contributor

ICEknigh7 commented Mar 19, 2024

No, it’s another case of a person mixing unrelated things together, and repeatedly adding to it. Every time I go to try and salvage non-contentious parts from it, I find it’s changed again.

Of course a softlist PR will get new changes after months of not being merged. Entries will keep getting added to it and additional fixes will be made.

@Osso13 Osso13 merged commit 53764e0 into mamedev:master Mar 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants