Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New NOT_WORKING machine (Vocalizer 1000) #12037

Merged
merged 3 commits into from
Feb 17, 2024
Merged

New NOT_WORKING machine (Vocalizer 1000) #12037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8011b0
New NOT_WORKING machine
devinacker Feb 10, 2024
0a07807
feedback [skip ci]
devinacker Feb 16, 2024
117a84c
misc/vocalizer.cpp: srcclean and tidy
cuavas Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/mame/mame.lst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32059,6 +32059,9 @@ nevada //
beezerk //
vlcunk //

@source:misc/vocalizer.cpp
vocalizer

Comment on lines +32062 to +32064
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you abbreviate the short name to fit it in eight characters to avoid “short name length inflation”?

Copy link
Member

@happppp happppp Feb 16, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to keep it as-is, I'm ok with 9 letter shortnames when there's no nice way to abbreviate it. @devinacker your choice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, “voclizer” and “vocalizr” both read fine and fit in eight characters.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree that those 2 examples are sensible to type when starting mame from cmdline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please relax this "8 letter limit at all costs" suggestion, it's frankly silly for stuff like megadriv, I don't want to struggle with MAME CLI suggestions more than enough already.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is, you still need to memorise the short names for things you use frequently, and I don’t want to have to type excessively long short names at the command line all the time. It’s already annoying enough with the length of short names for software lists when you need to type a fully qualified list:item:part identifier.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any word with 1 letter removed is more annoying to type than the full word.
Well, except for "a" or "I" :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then people will start complaining about things having a letter or two dropped to fit nine characters, and then ten characters, and so on.

You follow this to its conclusion and we end up with short names no longer being short and getting close to the 16 character limit on everything, and then you end up having trouble fitting suffixes for clones again. Then there’s pressure to extend the limit again.

Short names are supposed to be short identifiers that can be quickly and easily typed, don’t make for excessively long URLs, etc.

Copy link
Member

@happppp happppp Feb 16, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that what you're worried about? It doesn't happen (or if it does, show me where).
When I pick (parent set) shortnames, my max is 9, except for game&watch with their gnw_ prefix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO using a full nine-letter word isn't any less convenient than having to remember to spell it with one fewer vowel or what have you. I'm not really attached to any particular naming, though.

@source:misc/voyager.cpp
voyager // (c) 2002 Team Play, Inc.
voyagers // (c) 2002 Team Play, Inc.
Expand Down