machine/z80scc.cpp: Added support for RTxC transmit/receive clock source #12050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinleroy
changed the title
cuavas
requested changes
Feb 21, 2024
Fixes serial emulation at 115200 or 230400bps.
colinleroy
force-pushed
the
z80scc-implement-rtxc-clock-source
branch
from
1c4fac4
to
4d91bb0
Compare
cuavas
reviewed
Feb 22, 2024
There was a problem hiding this comment.
The code looks OK and matches the style of the file now.
Could someone who’s more familiar with the Z8530, and its implementation in MAME, please check to ensure this matches the documented behaviour and isn’t baking in overly specific assumptions about how the chip is hooked up in the system?
Maybe @rb6502, @pmackinlay or @MooglyGuy since you’ve worked on systems using the Z8530?
cuavas
changed the title
Mokona
pushed a commit
to Mokona/mame
that referenced
this pull request
Feb 28, 2024
Fixes serial emulation at 115200 or 230400bps. Co-authored-by: Colin Leroy-Mira <colin.leroy-mira@sigfox.com>
stonedDiscord
pushed a commit
to stonedDiscord/mame
that referenced
this pull request
Apr 8, 2024
Fixes serial emulation at 115200 or 230400bps. Co-authored-by: Colin Leroy-Mira <colin.leroy-mira@sigfox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes serial emulation at 115200bps.
This leaves some things unimplemented (like TRxC and DPLL clock sources), but makes programs communicating at 115.200bps function properly.
For context, toggling this chip to 115200bps or 230400bps is done by
I hope this is a good first PR.
Thanks!