Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msx2_cart.xml: Added 6 items, 5 working. #12052

Merged
merged 4 commits into from Feb 24, 2024
Merged

Conversation

wilbertpol
Copy link
Contributor

@wilbertpol wilbertpol commented Feb 21, 2024

machine/mb87030.cpp: Fix some bit definitions for the SCMD register. [pmackinlay]

msx2_cart.xml: Added 6 items, 5 working. [Wilbert Pol]

New working software list items

MEGA-SCSI (1024KB) [file-hunter, Wilbert Pol]
MEGA-SCSI (512KB) [file-hunter, Wilbert Pol]
MEGA-SCSI (256KB) [file-hunter, Wilbert Pol]
MEGA-SCSI (128KB) [file-hunter, Wilbert Pol]
DSKPRO (v11.6) [file-hunter]

New NOT_WORKING software list additions

Video Digitizer (Japan) [file-hunter]

Comment on lines 3586 to 3590
<description>HBI-V1 Video Digitizer (Japan)</description>
<year>1989</year>
<publisher>Sony</publisher>
<notes>Digitizer cartridge not emulated.</notes>
<info name="alt_title" value="ビデオデジタイザー"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you’re including the model number in the title, it should probably be in both titles. I’d probably make it “Video Digitizer HBI-V1 (Japan)” and “ビデオデジタイザー HBI-V1” as the box and manual have “Video Digitizer” most prominent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the HBI-V1 part from the description to match the Japanese name on the box and manual.

Comment on lines 6 to 9
#include "bus/nscsi/devices.h"
#include "machine/nscsi_bus.h"
#include "machine/mb87030.h"
#include "machine/wd33c9x.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include statements not sorted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted the includes

constexpr static uint8_t SCMD_RST_OUT = 0x08;
constexpr static uint8_t SCMD_PRG_XFER = 0x04;
constexpr static uint8_t SCMD_INTERCEPT_XFER = 0x08;
constexpr static uint8_t SCMD_RST_OUT = 0x10;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that this doesn’t break the HP9000/300 series machines that use this device?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before and after this change the hp9k drivers fail to boot the os from the hdd image in the software list resulting in a 'Root device busy' message and halting the boot process.
Similarly trying to install the os on a clean harddisk image results in an error when creating the filesystem.

bus/msx/cart/scsi.cpp: Sort includes.
@cuavas cuavas merged commit dcc48ae into mamedev:master Feb 24, 2024
6 checks passed
@wilbertpol wilbertpol deleted the msx2_cart branch February 25, 2024 10:24
Mokona pushed a commit to Mokona/mame that referenced this pull request Feb 28, 2024
* machine/mb87030.cpp: Fix some bit definitions for the SCMD register. [Patrick Mackinlay]
* bus/msx/cart/scsi.cpp: Add partial support for MegaSCSI SCSI interface cartridges. [Wilbert Pol]

New working software list items (msx2_cart.xml)
-------------------------------
MEGA-SCSI (1024KB) [file-hunter, Wilbert Pol]
MEGA-SCSI (512KB) [file-hunter, Wilbert Pol]
MEGA-SCSI (256KB) [file-hunter, Wilbert Pol]
MEGA-SCSI (128KB) [file-hunter, Wilbert Pol]
DSKPRO (v11.6) [file-hunter]

New software list items marked not working (msx2_cart.xml)
------------------------------------------
Video Digitizer (Japan) [file-hunter]
stonedDiscord pushed a commit to stonedDiscord/mame that referenced this pull request Apr 8, 2024
* machine/mb87030.cpp: Fix some bit definitions for the SCMD register. [Patrick Mackinlay]
* bus/msx/cart/scsi.cpp: Add partial support for MegaSCSI SCSI interface cartridges. [Wilbert Pol]

New working software list items (msx2_cart.xml)
-------------------------------
MEGA-SCSI (1024KB) [file-hunter, Wilbert Pol]
MEGA-SCSI (512KB) [file-hunter, Wilbert Pol]
MEGA-SCSI (256KB) [file-hunter, Wilbert Pol]
MEGA-SCSI (128KB) [file-hunter, Wilbert Pol]
DSKPRO (v11.6) [file-hunter]

New software list items marked not working (msx2_cart.xml)
------------------------------------------
Video Digitizer (Japan) [file-hunter]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants