emu/save.cpp: Make illegal save state registrations always fatal #12054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC the only times I saw that warning is with ethernet networking.
…On Thu, Feb 22, 2024 at 3:54 PM Vas Crabb ***@***.***> wrote:
The only thing that causes non-fatal illegal save state registrations
right now is registering an item for save states after start in a system
not marked as supporting save states.
It’s high time anything doing that gets fixed. Not supporting save states
means save state support is incomplete, not that the driver has a license
to do illegal things.
Opening this as a pull request to give fair warning, and so it can be
merged after freeze.
------------------------------
You can view, comment on, or merge this pull request online at:
#12054
Commit Summary
- 9cf425b
<9cf425b>
emu/save.cpp: Made illegal save state registrations always fatal.
File Changes
(3 files <https://github.com/mamedev/mame/pull/12054/files>)
- *M* src/emu/machine.cpp
<https://github.com/mamedev/mame/pull/12054/files#diff-3ae75dd5659ac8743c39fe4341ce19bbaff8d7cdaf629d075fd4dd8f3027b736>
(4)
- *M* src/emu/save.cpp
<https://github.com/mamedev/mame/pull/12054/files#diff-7079b0b4881e1abe34ebc3a48d78cd755ac713255c93f1ca9af4b97aa9f7d68c>
(22)
- *M* src/emu/save.h
<https://github.com/mamedev/mame/pull/12054/files#diff-b5ffe59ae2eebd4e60c0c24fc48ab26023dc02ae2238c962ce9b75b617ab97cc>
(2)
Patch Links:
- https://github.com/mamedev/mame/pull/12054.patch
- https://github.com/mamedev/mame/pull/12054.diff
—
Reply to this email directly, view it on GitHub
<#12054>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACGSF4PD4JXL62VA4PRTZHDYU5LZXAVCNFSM6AAAAABDVDDBFCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DSMRWGA2DEOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Ah right, because it has an emu_timer in an OSD module. There’s just so much wrong with that it isn’t funny. I’ve wanted to get rid of that for ages. I guess this means I have to do it. |
|
+1 on the network layer having so much wrong it's not funny. It's difficult even to trace the flow of control. |
Mokona
pushed a commit
to Mokona/mame
that referenced
this pull request
Feb 28, 2024
stonedDiscord
pushed a commit
to stonedDiscord/mame
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing that causes non-fatal illegal save state registrations right now is registering an item for save states after start in a system not marked as supporting save states.
It’s high time anything doing that gets fixed. Not supporting save states means save state support is incomplete, not that the driver has a license to do illegal things.
Opening this as a pull request to give fair warning, and so it can be merged after freeze.