util/bitstream: Adjust m_doffset based on m_dbitoffs when flushing #12060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If anyone wants this in master before I do a merge myself, please use a merge commit rather than cherry-picking (i.e. |
987123879113
referenced
this pull request
Feb 24, 2024
…ing and writing. (#12057) * In some cases, bits would be dropped when writing if there wasn't enough space in the buffer. * Fixes bad hunk maps being written to CHD files and incorrect hunk map data being read.
Mokona
pushed a commit
to Mokona/mame
that referenced
this pull request
Feb 28, 2024
…mamedev#12060) Fixes issues exposed when reading LaserDisc CHDs.
stonedDiscord
pushed a commit
to stonedDiscord/mame
that referenced
this pull request
Apr 8, 2024
…mamedev#12060) Fixes issues exposed when reading LaserDisc CHDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that in addition to forgetting to clear
m_dbitoffswhen flushing resulting in data being shifted incorrectly after a flush whenm_dbitoffswas non-0, the variablem_doffsetwould go out of sync after flushing whenm_dbitoffswas used so that needed to be adjusted as well.I've tested with
chdman infoto check that the 175 CHDs I have on hand can still decompress the map data still, recreated the delta CHD (chdman copy -i ~/chd_test/gdj_aaa_2007071100.chd -op ~/chd_test/gdj_aaa_2007100800.chd -o ~/chd_test/newchild5.chd) and verified that all of the hashes validated, and then did various tests using thedlairlaserdisc CHD including extracting usingchdman extractld, recreating usingchdman createld, and verifying that the SHA1 and Data SHA1 were the same in the original CHD and the recreated CHD.