gdbstub fixes for Windows and m68000 #12067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge trunk
gdbstub: fix m68000 register names
Mokona
pushed a commit
to Mokona/mame
that referenced
this pull request
Feb 28, 2024
gdbstub: fix m68000 register names
cuavas
reviewed
Mar 25, 2024
| @@ -682,6 +682,9 @@ static std::string escape_packet(const std::string src) | |||
| result.reserve(src.length()); | |||
| for ( char ch: src ) | |||
| { | |||
| if ( ch == '\n' ) // don't let socket convert line endings and messing up the checksum | |||
| continue; | |||
|
|
|||
There was a problem hiding this comment.
Wouldn’t the proper solution to this be to change the calls to m_socket.puts(...) to use m_socket.write(...) instead to avoid text conversion altogether? This looks like working around the issue rather than actually fixing it.
There was a problem hiding this comment.
yeah, probably. wasn't familiar with the socket interface :)
stonedDiscord
pushed a commit
to stonedDiscord/mame
that referenced
this pull request
Apr 8, 2024
gdbstub: fix m68000 register names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debug_gdbstub::generate_target_xml()contained newlines that were converted from '\n' to '\r\n' on Windows, thus breaking the gdb packet checksum (debug_gdbstub::send_reply), so removed newlines inescape_packet. GDB doesn't care about newlines in XML files. This seemed to be the least invasive fix I could think of.A7=>SP,PC=>CURPCI guess we should rename other instances of
PCtoCURPCas well, asdevice_state_entry::device_state_entry()automatically changes the name of PC toCURPC(see distate.cpp line 66)