spi_sdcard.cpp: implement SEND_CSD (SD_TYPE_V2) #12078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rb6502
reviewed
Feb 28, 2024
| m_data[1] = 0xff; | ||
| m_data[2] = 0xfe; | ||
|
|
||
| //if (m_type == SD_TYPE_V2) // CSD Version 1.0 |
There was a problem hiding this comment.
If this check isn't necessary, remove it. (If it is, comment it back in). Same for the else block below.
There was a problem hiding this comment.
It's necessary for 2.0. I just don't have a case to test it but clearly it must be revisited and implemented at some point
There was a problem hiding this comment.
Ok, that's fair. I'm a big proponent of not implementing things you don't have a test case for.
stonedDiscord
pushed a commit
to stonedDiscord/mame
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.