cpu/hcd62121: Implement missing mov instructions and timer wait #12099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: George Stagg <georgestagg@gmail.com>
stonedDiscord
pushed a commit
to stonedDiscord/mame
that referenced
this pull request
Apr 8, 2024
…dev#12099) Co-authored-by: George Stagg <georgestagg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes bring emulation closer to the intended speed, allowing screens in CFX9850 models to be interacted without the system turning off immediately (instead of the intended 6 minutes of idle time).
George Stagg identified some missing instructions and how timers were set. In particular, that instruction 0xB3 sets the timeout for the next sleep operation at instruction 0xFE.
Concrete values for timeouts are based on test ROMs I wrote to iterate over almost all possible parameters, using a logic analyzer to get approximate durations for each timeout. If anyone is interested in checking out these timings, you can open these traces in DSView, using the sigrok decoder found on the same repo.