machine/t10mmc: Fix MSF to LBA conversion for T10MMC_CMD_PLAY_AUDIO_MSF #12113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987123879113
force-pushed
the
t10mmc_play_audio_msf
branch
from
a16d2ea
to
990265c
Compare
987123879113
commented
Mar 9, 2024
Comment on lines
973
to
+974
| uint32_t msf = to_msf(m_lba); | ||
| data[data_idx] = BIT(msf, 16, 8); | ||
| data[data_idx+1] = BIT(msf, 8, 8); | ||
| data[data_idx+2] = BIT(msf, 0, 8); | ||
| put_u24be(&data[data_idx], msf); |
There was a problem hiding this comment.
While auditing all usages of to_msf in t10mmc when I noticed this was the only one that didn't do lba+150. I checked a mode 2 CD image I had on hand and the first sector's timestamp starts at 00:02:00, so not having lba+150 here was a bug. The new to_msf adds the +150 so this should be fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes audio being noticeably out of sync in pumpit1. The current dump of pumpit1 was thought to be a bad dump previously due to this bug, but T10MMC_CMD_PLAY_AUDIO_MSF had its own MSF to LBA conversion code which did not adjust the LBA value as shown in the formula below which was causing all songs played via the MSF playback command to be 2 seconds off.
ref: MMC-3 draft
