Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formats/dmk_dsk.cpp: Improve checks in identify. #12118

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

wilbertpol
Copy link
Contributor

And be more lenient towards images where the amount of stored tracks does not match the amount of tracks set in the header.

@ajrhacker
Copy link
Contributor

ajrhacker commented Mar 9, 2024

I've thought about this subject since the discussion on #12062, and I've come to the conclusion that performing such "structural" checks on stored data is simply not warranted, especially due to the high priority of FIFID_STRUCT. It's way too common for fields such as volume names to disagree with official or unofficial specifications.

@wilbertpol
Copy link
Contributor Author

I guess that depends on how you interpret structure: the structure of the file format or the structure of the actual data stored in the file.
If FIFID_STRUCT a too high a priority for the simple file format checks done here then it'd be better to use FIFID_HINT?

@ajrhacker
Copy link
Contributor

@galibert commented on #12062 that "Pure sector formats can't have a structural or a signature check in any case." I blame him for not making that clear when he added FIFID_STRUCT.

@wilbertpol
Copy link
Contributor Author

Right, then both FIFID_STRUCT and FIFID_SIGN are too strong for this format. I changed it to use FIFID_HINT.

@wilbertpol wilbertpol changed the title formats/dmk_dsk.cpp: Add structure checks in identify. formats/dmk_dsk.cpp: Improve checks in identify. Mar 12, 2024
@rb6502 rb6502 merged commit 699b8b5 into mamedev:master Mar 22, 2024
5 checks passed
@wilbertpol wilbertpol deleted the dmk_dsk_struct branch March 31, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants