megadriv.xml: Fixed descriptions, added notes #12171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied one, fixed titles, added info Not working entry added (for use with the HeartBeat Catalyst fitness sensor): - Outback Joey (HeartBeat Personal Trainer) [Nikaotix] Bad Dump replaced with verified one: - Férias Frustradas do Pica-Pau (Brazil) (fixes GitHub Issue mamedev#11950) [MARCSLASH, arthurthekidboy] Clones added: - Sonic The Hedgehog (World, JP2, ripped from Sonic Mega Collection) [Sonic Cult, SonicBlur, Just Me, Haku Ronin] - Sonic The Hedgehog 2 (prototype 199209xx, pirate) [drx, Hidden Palace] Fixed descriptions, added info, added entries to lists of missing dumps. Should contain all the info from the closed PR mamedev#11353 in an easier-to-review form (without grouping the Sega Game Toshokan titles into their own section or doing additional cleanups).
angelosa
requested changes
Mar 22, 2024
There was a problem hiding this comment.
I cite myself:
What he said: either fix the conflicts or start over, 6 months (& 5 reviewers) for a XML change that should've split in at least 3 different PRs is far from ideal.
What do you want here:
- the Personal Trainer new dump?
- the Férias Frustradas do Pica-Pau new pirate dump?
- changes over Sega Game Toshokan?
I don't care it's the same file, 1 and 2 don't fit 3 at all, essentially not fitting neither gitflow (not enough) nor trunk-based approaches (too much).
|
Ok, no Sega Game Toshokan fixes, then. Moved them here: #12172 |
|
I'm also removing the Personal Trainer stuff, should make the PR easier to review. |
PR is easier to review now.
ICEknigh7
changed the title
ICEknigh7
changed the title
|
Splitting this one into two. |
ICEknigh7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some descriptions and added some notes.