Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snes.xml: Added a prototype. #12185

Merged
merged 2 commits into from
Mar 29, 2024
Merged

snes.xml: Added a prototype. #12185

merged 2 commits into from
Mar 29, 2024

Conversation

FoxhackDN
Copy link
Contributor

New working software list items (snes.xml)

Rockman's Soccer (Japan, sample) [C. Davis]

New working software list items (snes.xml)
-------------------------------
Rockman's Soccer (Japan, sample) [C. Davis]
<part name="cart" interface="snes_cart">
<feature name="slot" value="lorom" />
<dataarea name="rom" size="1572864">
<rom name="rockman's soccer (prototype).sfc" size="1572864" crc="B999B148" sha1="28E030ACD8A41DE9CA8F6AED5144D3DD85DE6D11" offset="0x000000" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use lowercase hex digits, and keep the size and offset together when adding ROMs to make things more readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the uppercase hashes, fixed now. I think I moved the offset to where you want but if not just lemme know.

@cuavas cuavas merged commit a17efb0 into mamedev:master Mar 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants