strtdriv: fixed incorrect brake pedal port mapping in harddriv.cpp #12192
Conversation
Fixed wrongly mapped brake pedal input from 8ADC:6 to 8ADC:2 and swapped the Voice Mic function which is unused from 8ADC:2 to 8ADC:6 to avoid any conflict/loss of functionality. Steering input still needs to be fixed (if you turn to the far left of right the centre point of the steering wheel will shift and constantly pull the wheel in the opposite direction) Hard Drivin's Airborne has the same problem. Will try to fix that if I can and update the code here on GitHub.
|
Uh, what even is "Voice Mic"? Is it actually used by anything on this HW? |
I think it was meant to listen to the noise around the machine to give statistics to the arcade owners about how popular the game is and what the busiest times of day are in the test menu? I might be wrong but i think i vaguely remember reading that. Instead of just removing it i swapped it to the 8-Bit ADC port that the brake was wrongly assigned to (8ADC:6) as it doesn't seem to be used or make a difference to the games functionality. I thought by swapping them around it could make it easier for people to maybe get it working in future if it is possible and would save them having to add the code back in manually as it's still right there in front of them waiting to be edited. This is my first time doing anything on MAME or GitHub and i don't know any coding languages so please forgive me if i seem ignorant or didn't follow etiquette when making this commit. |
|
Do you know it’s supposed to be on that ADC channel? Is there a schematic showing the connections, or can you see the code accessing ADC channel 6? |
The brake was originally mapped in MAME to be on ADC channel 6 and it wasn't working because it was supposed to be on ADC channel 2 but that channel was already assigned to the "voice mic" in the code so i just swapped them around so that the brake would work but i have no clue what ADC channel the voice mic should be connected to. It's a Prototype arcade game that was never released and only a few machines were ever made so i don't even know if there is a schematic for it online anywhere. I think it uses the same hardware as Hard Drivin's Airborne which is a prototype too. |
|
Better to make the comment less confident and say it’s possibly the voice mic input if there’s no other supporting evidence. |
Sorry if i sound silly but how would I write that to the code? Could i add this on the end of the line of code or above it? "/* Placeholder ADC port for voice mic, NOT tested or verified! */" I'm learning as i go along it's why I'm not sure what is the best way to add that information to the code! |
|
I'd go with something like "ADC input for voice mic? Not verified". |
…voice mic" ADC channel is a placeholder that has not been tested or verified as working in harddriv.cpp Swapped brake input from ADC channel 6 to ADC channel 2 to fix the broken brake input functionality. Swapped "voice mic" from ADC channel 2 to ADC channel 6 as a placeholder only as it has NOT been tested or verified as working yet and may be unused.
|
Just update the comment on the |
Sorry i already added the extra line can i just edit it again so that it's the way you both suggested it to be? |
Yes, just edit it again. It gets squashed to a single commit on merge anyway. |
…ddriv.cpp Updated the original comment on the untested/unverified voice mic ADC input instead of adding a extra comment to the code above it as suggested by rb6502 and cuavas.
Fixed wrongly mapped brake pedal input from 8ADC:6 to 8ADC:2 and swapped the Voice Mic function which is unused from 8ADC:2 to 8ADC:6 to avoid any conflict/loss of functionality. Steering input still needs to be fixed (if you turn to the far left of right the centre point of the steering wheel will shift and constantly pull the wheel in the opposite direction) Hard Drivin's Airborne has the same problem. Will try to fix that if I can and update the code here on GitHub.