Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Roland JV880 roms info #12227

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Added Roland JV880 roms info #12227

merged 2 commits into from
Apr 10, 2024

Conversation

giulioz
Copy link
Contributor

@giulioz giulioz commented Apr 8, 2024

How do I submit the rom files?

@giulioz giulioz changed the title Added JV880 roms info Added Roland JV880 roms info Apr 8, 2024
@ajrhacker
Copy link
Contributor

How do I submit the rom files?

See the instructions on https://wiki.mamedev.org/index.php/Submitting_Source_Code.

@cuavas cuavas merged commit e261a94 into mamedev:master Apr 10, 2024
5 checks passed
@cuavas
Copy link
Member

cuavas commented Apr 10, 2024

You have a Unicode bidirectional override character in your GitHub display name. This ends up in the “real name” field for commit messages for squashed pull request commits. It causes display issues because the commit message is displayed in reverse order. Please fix it.

@giulioz
Copy link
Contributor Author

giulioz commented Apr 10, 2024

@cuavas fixed!

@cuavas
Copy link
Member

cuavas commented Apr 10, 2024

Thanks. Do you know how it got there in the first place?

(Using these characters to screw up page display on forums used to be a common attack in the early days of Unicode support on web forums. But we’ve now seen a trailing U+202E character in multiple GitHub display names.)

@Tafoid
Copy link
Contributor

Tafoid commented Apr 13, 2024

@cuavas fixed!

@giulioz
Your PR was committed to source and Dev is still looking for the ROM data that matches it for verification. Please send this in via the instructions on link posted earlier ASAP.

Thank you for your contribution.

@giulioz
Copy link
Contributor Author

giulioz commented Apr 13, 2024

@Tafoid I sent it, but I'm getting an error:

The recipient server did not accept our requests to connect]

Any other option?

@Tafoid
Copy link
Contributor

Tafoid commented Apr 13, 2024

Odd. That was attempting to email?
I'm emailing your Github connected email - simply reply with any DATA or supporting documents (manuals/pcb pictures/etc).

Thanks!
Tafoid

@mamedev mamedev deleted a comment from FoxhackDN Apr 13, 2024
@Axis4s
Copy link

Axis4s commented Apr 13, 2024

I Have found waverom A & B for the 880 but they have different hash.
did the waveroms ever got some sort of revision?

@giulioz giulioz deleted the jv880_roms branch April 15, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants