itech/itech32.cpp: Various cleanups and updates: #12231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recuce runtime tag macros Fix metadatas (ex: shufshot and clones are hasn't strata related stuff (logo, etc)) Use machine().side_effects_disabled() for debug stuffs Use correct, constant typename values Fix naming for ROM regions Use logmacro for logging features Use C++ style comments for single line comments Reduce defines Use array for reduce duplicates Move drivedge specific stuffs into drivedge_state
cuavas
reviewed
Apr 10, 2024
| #define SOUND_CLOCK XTAL(16'000'000) // clock for sound board | ||
| #define TMS_CLOCK XTAL(40'000'000) // TMS320C31 clocks on drivedge | ||
|
|
||
| #define LOG_DRIVEDGE_UNINIT_RAM 0 |
There was a problem hiding this comment.
Is there a specific reason you moved this macro to the header? It only seems to be used in one file. I’d understand if you were going to use it to avoid creating the m_written member at all if it’s disabled or something. But it doesn’t seem to be used in the header at all.
There was a problem hiding this comment.
That's for avoid to create RAM logging related variables and functions.
Fix naming for drivedge RAM log functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recuce runtime tag macros
Fix metadatas (ex: shufshot and clones are hasn't strata related stuff (logo, etc)) Use machine().side_effects_disabled() for debug stuffs Use correct, constant typename values
Fix naming for ROM regions
Use logmacro for logging features
Use C++ style comments for single line comments
Reduce defines
Use array for reduce duplicates
Move drivedge specific stuffs into drivedge_state