Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itech/itech32.cpp: Various cleanups and updates: #12231

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

cam900
Copy link
Contributor

@cam900 cam900 commented Apr 10, 2024

Recuce runtime tag macros
Fix metadatas (ex: shufshot and clones are hasn't strata related stuff (logo, etc)) Use machine().side_effects_disabled() for debug stuffs Use correct, constant typename values
Fix naming for ROM regions
Use logmacro for logging features
Use C++ style comments for single line comments
Reduce defines
Use array for reduce duplicates
Move drivedge specific stuffs into drivedge_state

Recuce runtime tag macros
Fix metadatas (ex: shufshot and clones are hasn't strata related stuff (logo, etc))
Use machine().side_effects_disabled() for debug stuffs
Use correct, constant typename values
Fix naming for ROM regions
Use logmacro for logging features
Use C++ style comments for single line comments
Reduce defines
Use array for reduce duplicates
Move drivedge specific stuffs into drivedge_state
src/mame/itech/itech32.cpp Outdated Show resolved Hide resolved
#define SOUND_CLOCK XTAL(16'000'000) // clock for sound board
#define TMS_CLOCK XTAL(40'000'000) // TMS320C31 clocks on drivedge

#define LOG_DRIVEDGE_UNINIT_RAM 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason you moved this macro to the header? It only seems to be used in one file. I’d understand if you were going to use it to avoid creating the m_written member at all if it’s disabled or something. But it doesn’t seem to be used in the header at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's for avoid to create RAM logging related variables and functions.

Fix naming for drivedge RAM log functions
@cuavas cuavas merged commit 78ef444 into mamedev:master Apr 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants