uknc.cpp: hook up cassette and floppy #12254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Apr 15, 2024
src/devices/bus/qbus/uknc_kmd.h
Outdated
Comment on lines
31
to
34
| protected: | ||
| // device-level overrides | ||
| virtual void device_start() override; | ||
| virtual void device_add_mconfig(machine_config &config) override; |
There was a problem hiding this comment.
Please don’t copy/paste the “device-level overrides” comment – it doesn’t even make sense. Use “device_t implementation” or something if you want a comment for the overridden device_t member functions.
src/devices/bus/qbus/uknc_kmd.h
Outdated
Comment on lines
38
to
39
| private: | ||
| static void floppy_formats(format_registration &fr); |
There was a problem hiding this comment.
If this is private and doesn’t need to access other class members, it doesn’t need to be a class member at all. You can throw it in an anonymous namespace and keep it out of the header.
src/devices/bus/qbus/uknc_kmd.h
Outdated
Comment on lines
14
to
16
| #include "machine/1801vp128.h" | ||
|
|
||
| #include "qbus.h" |
There was a problem hiding this comment.
Local headers should come first. It helps avoid headers that don’t #include everything they need.
src/devices/bus/qbus/uknc_kmd.cpp
Outdated
Comment on lines
9
to
14
| #include "emu.h" | ||
|
|
||
| #include "machine/pdp11.h" | ||
| #include "formats/bk0010_dsk.h" | ||
|
|
||
| #include "uknc_kmd.h" |
There was a problem hiding this comment.
The translation unit’s header should be the first thing after the prefix header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.