misc/coolpool.cpp: Cleanups #12295
Merged
misc/coolpool.cpp: Cleanups #12295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split driver state for reduce optional finders Use palette_device for amerdart palette Suppress side effects for debugger read Constantize variables Use logmacro.h for logging functions Use C++ style comments for single line comments Use std::swap for swap function
cuavas
requested changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split driver state to reduce optional finders
Use palette_device for amerdart palette
Suppress side effects for debugger read
Constantize variables
Use logmacro.h for logging functions
Use C++ style comments for single line comments
Use std::swap for swap function