seta/ssv.cpp: Cleanups #12349
Merged
seta/ssv.cpp: Cleanups #12349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cam900
commented
May 7, 2024
cam900
commented
- Split driver state class for with DSP
- Use C++ style comments for single line comments
- Suppress side effects for debugger read
- Reduce preprocessor defines
- Reduce duplicate
- Fix spacing
- Reduce unnecessary lines
- Constantize variables
- Fix typename values
- Fix document
- Reduce usage of literal tags
- Reduce runtime tag lookup
- Use generic gfx decode layout for gdfs tilemap
- Fix naming for ROM region and tags
- Split driver state class for with DSP - Use C++ style comments for single line comments - Suppress side effects for debugger read - Reduce preprocessor defines - Reduce duplicate - Fix spacing - Reduce unnecessary lines - Constantize variables - Fix typename values - Fix document - Reduce usage of literal tags - Reduce runtime tag lookup - Use generic gfx decode layout for gdfs tilemap - Fix naming for ROM region and tags
rb6502
reviewed
May 8, 2024
rb6502
reviewed
May 8, 2024
rb6502
reviewed
May 8, 2024
rb6502
reviewed
May 8, 2024
|
This is a big improvement for that driver! Just a few minor notes to get it a little bit cleaner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.