Add a new Jump Bug bootleg on Galaxian hardware #12350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New working clone ----------------------- Jump Bug (bootleg, set 2) [Arcadedealer aka Edgar Solé aka Dios, Recreativas.org]
Osso13
reviewed
May 10, 2024
src/mame/galaxian/galaxian.cpp
Outdated
| @@ -2537,6 +2537,27 @@ void galaxian_state::jumpbug_map(address_map &map) | |||
| map(0xb000, 0xbfff).r(FUNC(galaxian_state::jumpbug_protection_r)); | |||
| } | |||
|
|
|||
| // Same as 'jumpbug_map' but without the AY-8910 | |||
There was a problem hiding this comment.
If it's just that, then you might be able to update the jumpbug_map to call this one and just have the AY methods in there.
something like:
void galaxian_state::jumpbug_map(address_map &map)
{
jumpbugbrf_map(map);
AY methods here
}
src/mame/galaxian/galaxian.cpp
Outdated
| { | ||
| galaxian_base(config); | ||
| galaxian_base(config); |
There was a problem hiding this comment.
What's changing here and below? Could you run srcclean on this?
udance4ever
pushed a commit
to udance4ever/mame
that referenced
this pull request
May 16, 2024
New working clones ----------------------- Jump Bug (bootleg, set 2) [Arcadedealer aka Edgar Solé aka Dios, Recreativas.org]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New working clone
Jump Bug (bootleg, set 2) [Arcadedealer aka Edgar Solé aka Dios, Recreativas.org]