Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Jump Bug bootleg on Galaxian hardware #12350

Merged
merged 4 commits into from
May 15, 2024

Conversation

clawgrip
Copy link
Contributor

@clawgrip clawgrip commented May 7, 2024

New working clone

Jump Bug (bootleg, set 2) [Arcadedealer aka Edgar Solé aka Dios, Recreativas.org]

New working clone
-----------------------
Jump Bug (bootleg, set 2) [Arcadedealer aka Edgar Solé aka Dios, Recreativas.org]
@clawgrip clawgrip marked this pull request as draft May 8, 2024 08:03
@clawgrip clawgrip marked this pull request as ready for review May 8, 2024 08:19
Copy link
Member

@Osso13 Osso13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions

@@ -2537,6 +2537,27 @@ void galaxian_state::jumpbug_map(address_map &map)
map(0xb000, 0xbfff).r(FUNC(galaxian_state::jumpbug_protection_r));
}

// Same as 'jumpbug_map' but without the AY-8910
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's just that, then you might be able to update the jumpbug_map to call this one and just have the AY methods in there.

something like:
void galaxian_state::jumpbug_map(address_map &map)
{
jumpbugbrf_map(map);

 AY methods here

}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!! Thanks!

{
galaxian_base(config);
galaxian_base(config);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's changing here and below? Could you run srcclean on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@Osso13 Osso13 merged commit d693b3f into mamedev:master May 15, 2024
5 checks passed
udance4ever pushed a commit to udance4ever/mame that referenced this pull request May 16, 2024
New working clones
-----------------------
Jump Bug (bootleg, set 2) [Arcadedealer aka Edgar Solé aka Dios, Recreativas.org]
@clawgrip clawgrip deleted the jumpbugbrf branch May 16, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants