-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
casio/fp1100.cpp: Add FP1000 #12358
casio/fp1100.cpp: Add FP1000 #12358
Conversation
New not working machine ----------------------------- FP-1000 [OldComputers ES]
src/mame/casio/fp1100.cpp
Outdated
// Drivers | ||
|
||
/* YEAR NAME PARENT COMPAT MACHINE INPUT CLASS INIT COMPANY FULLNAME FLAGS */ | ||
// YEAR NAME PARENT COMPAT MACHINE INPUT CLASS INIT COMPANY FULLNAME FLAGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dislike this cargo cult, it's outdated and it throws bad habits for people using this as a net safety for something they should look at where the macro is actually located.
Could you please get rid of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
src/mame/casio/fp1100.cpp
Outdated
COMP( 1983, fp1100, 0, 0, fp1100, fp1100, fp1100_state, empty_init, "Casio", "FP-1100", MACHINE_NOT_WORKING) | ||
COMP( 1982, fp1000, 0, 0, fp1100, fp1100, fp1100_state, empty_init, "Casio", "FP-1000", MACHINE_NOT_WORKING) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should either be parent/clone, or one marked as “compatible” with the other (the fourth parameter to the COMP
macro).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thank!
src/mame/casio/fp1100.cpp
Outdated
// FP1000 has less memory than FP1100, using the same PCB, but with unpopulated sockets from RAM9 to RAM24 (only RAM1 to RAM8 are populated). | ||
/* FP1000 has less memory than FP1100, using the same PCB, but with unpopulated sockets from RAM9 to RAM24 (only RAM1 to RAM8 are populated). | ||
The dumped PCB has the uPD7801G socket labeled as "uPD7801G-101", but the chip seems like a newer revision, silkscreened as "D7108G-118". */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any evidence that systems ever shipped with a chip with mask code 101? All the photos I’ve seen of FP1100 and FP1000 boards show a µPD7801G with mask code 118 while the PCB has “-101” on the silk screen. The µPD7801G is sometimes socketed and sometimes soldered.
This needs its own machine configuration with reduced video RAM, etc. There are more revisions out there. One has main CPU ROM “3E A10 KK” with SHA1 fca8b0d19460e3be5f51db0bfcfe94a7657b4bfd and µPD7801 program ROM “3E A1S GTA” with SHA1 b69026a1efe704f972510190a6cd1d8af19148fc. |
New not working machine
FP-1000 [OldComputers ES]