Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

casio/fp1100.cpp: Add FP1000 #12358

Merged
merged 6 commits into from
May 16, 2024
Merged

casio/fp1100.cpp: Add FP1000 #12358

merged 6 commits into from
May 16, 2024

Conversation

clawgrip
Copy link
Contributor

@clawgrip clawgrip commented May 9, 2024

New not working machine

FP-1000 [OldComputers ES]

New not working machine
-----------------------------
FP-1000 [OldComputers ES]
Comment on lines 731 to 733
// Drivers

/* YEAR NAME PARENT COMPAT MACHINE INPUT CLASS INIT COMPANY FULLNAME FLAGS */
// YEAR NAME PARENT COMPAT MACHINE INPUT CLASS INIT COMPANY FULLNAME FLAGS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike this cargo cult, it's outdated and it throws bad habits for people using this as a net safety for something they should look at where the macro is actually located.
Could you please get rid of it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Comment on lines 733 to 734
COMP( 1983, fp1100, 0, 0, fp1100, fp1100, fp1100_state, empty_init, "Casio", "FP-1100", MACHINE_NOT_WORKING)
COMP( 1982, fp1000, 0, 0, fp1100, fp1100, fp1100_state, empty_init, "Casio", "FP-1000", MACHINE_NOT_WORKING)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should either be parent/clone, or one marked as “compatible” with the other (the fourth parameter to the COMP macro).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank!

Comment on lines 717 to 718
// FP1000 has less memory than FP1100, using the same PCB, but with unpopulated sockets from RAM9 to RAM24 (only RAM1 to RAM8 are populated).
/* FP1000 has less memory than FP1100, using the same PCB, but with unpopulated sockets from RAM9 to RAM24 (only RAM1 to RAM8 are populated).
The dumped PCB has the uPD7801G socket labeled as "uPD7801G-101", but the chip seems like a newer revision, silkscreened as "D7108G-118". */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any evidence that systems ever shipped with a chip with mask code 101? All the photos I’ve seen of FP1100 and FP1000 boards show a µPD7801G with mask code 118 while the PCB has “-101” on the silk screen. The µPD7801G is sometimes socketed and sometimes soldered.

@cuavas cuavas merged commit 100cc0f into mamedev:master May 16, 2024
0 of 5 checks passed
@clawgrip clawgrip deleted the patch-7 branch May 16, 2024 19:38
@cuavas
Copy link
Member

cuavas commented May 16, 2024

This needs its own machine configuration with reduced video RAM, etc.

There are more revisions out there. One has main CPU ROM “3E A10 KK” with SHA1 fca8b0d19460e3be5f51db0bfcfe94a7657b4bfd and µPD7801 program ROM “3E A1S GTA” with SHA1 b69026a1efe704f972510190a6cd1d8af19148fc.

@angelosa
Copy link
Member

It also doesn't boot as things stands: lacks the actual IPL ROM as also noted by the FP-1000 French manual
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants