galaxian/galaxian.cpp: hook up Galaxian discrete sound for 'bongoa', rename set to indicate the different hardware #12360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kinda agree, it seems like an unofficial hack / conversion to run on different hardware, the code changes are patched in and not 'clean' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #12314, using this video as a reference. (I haven't attempted to figure out which color PROM the board in that video is using, though)
I was inclined to mark this set as a bootleg since the ROM differences are very clearly hacks on top of the parent set, but I'll wait for a second opinion on that.