seta/seta2.cpp: Cleanups #12364
Merged
seta/seta2.cpp: Cleanups #12364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cam900
commented
May 12, 2024
cam900
commented
- Use logmacro for logging functions
- Reduce runtime tag lookups
- Move mj4simai specific stuffs into mj4simai_state class
- Constantize variables
- Fix spacing
- Use correct typename values
- Reduce unnecessary lines
- Reduce duplicates
- Reduce literal tag usages
- Suppress side effects for debugger reads
- Reduce preprocessor defines
- USe C++ style comments for single line comments
- Fix initialization
- Use logmacro for logging functions - Reduce runtime tag lookups - Move mj4simai specific stuffs into mj4simai_state class - Constantize variables - Fix spacing - Use correct typename values - Reduce unnecessary lines - Reduce duplicates - Reduce literal tag usages - Suppress side effects for debugger reads - Reduce preprocessor defines - USe C++ style comments for single line comments - Fix initialization
udance4ever
pushed a commit
to udance4ever/mame
that referenced
this pull request
May 16, 2024
* Move mj4simai-specific stuff into derived mj4simai_state class. * Reduced literal tags and run-time tag lookups. * Suppress side effects for debugger reads. * Use logmacro.h logging utilities, made more variables const. * Use C++ line comments for single line comments, fixed spacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.