Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neogeo.xml: Added 10 working items #12367

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

ArcadeShadow
Copy link
Contributor

New working software list additions

Gladmort (demo) [PixelHeart]
NeoBlack Tiger (demo) [OzzyOuzo]
The Eye of Typhoon (alpha) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 1) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 2) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 3) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 4) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 5) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 6) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 7) [OzzyOuzo]

New working software list additions
--------------------------------------------
Gladmort (demo) [PixelHeart]
NeoBlack Tiger (demo) [OzzyOuzo]
The Eye of Typhoon (alpha) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 1) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 2) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 3) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 4) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 5) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 6) [OzzyOuzo]
The Eye of Typhoon (Tsunami Edition, beta 7) [OzzyOuzo]
@mamehaze
Copy link
Contributor

mamehaze commented May 12, 2024

I think 'The Eye of Typhoon (alpha)' needs a better description, as not to confuse it with the real unreleased prototype. This is a 'fan' remake/demake of the 3DO version with some extra features.

@FoxhackDN
Copy link
Contributor

I'm also not sure if "unlicensed 3rd party" is the right descriptor here, since it's technically a homebrew, fan-developed game.

@ICEknigh7
Copy link
Contributor

As confusing as things may get due to the mere existance of a fan remake of an unreleased game, I think the current entries are fine (the year and publisher tags already give away that it's not the original intended release), though perhaps some additional clarification could be included as a comment.

hash/neogeo.xml Outdated
Comment on lines 11805 to 11843
<software name="nblktiger">
<description>NeoBlack Tiger (demo)</description>
<year>2020</year>
<publisher>OzzyOuzo</publisher>
<sharedfeat name="release" value="MVS,AES" />
<sharedfeat name="compatibility" value="MVS,AES" />
<part name="cart" interface="neo_cart">
<dataarea name="maincpu" width="16" endianness="big" size="0x100000">
<rom loadflag="load16_word_swap" name="202-p1.bin" offset="0x000000" size="0x100000" crc="18f34200" sha1="78b3b9ef20ddf780a81e644d996d56dd5c0e6d10" />
</dataarea>
<dataarea name="fixed" size="0x20000">
<rom name="202-s1.bin" offset="0x000000" size="0x20000" crc="a545b593" sha1="09077b63595eebb7dddd55e041e7786164df0ead" />
</dataarea>
<dataarea name="audiocpu" size="0x100000">
<rom name="202-m1.bin" offset="0x000000" size="0x100000" crc="2037dc19" sha1="c88588d07fc63aeed828a87f0f633c7badafeb3e" />
</dataarea>
<dataarea name="ymsnd:adpcma" size="0x900000">
<rom name="202-v1.bin" offset="0x000000" size="0x100000" crc="3ac066e1" sha1="cab7f04fbce0db685f5fa0d22923f7b7ca37a804" />
<rom name="202-v2.bin" offset="0x100000" size="0x100000" crc="c5a12987" sha1="71236afffdb69aa3ba8ebc345e1e7b1830db437e" />
<rom name="202-v3.bin" offset="0x200000" size="0x100000" crc="3c623679" sha1="5fa98eacb612be496aa7937a9678398ba16f2a13" />
<rom name="202-v4.bin" offset="0x300000" size="0x100000" crc="fbf00c96" sha1="4083f8efbcf748dba31f0030b82487e0ea56980b" />
<rom name="202-v5.bin" offset="0x400000" size="0x100000" crc="9b2031d4" sha1="15c8f5cb26af29b8dca53f1c1c49384a1b73b820" />
<rom name="202-v6.bin" offset="0x500000" size="0x100000" crc="107cfc89" sha1="c4ced7dfab24ff42c6fc2424b18cf199ba30cbfa" />
<rom name="202-v7.bin" offset="0x600000" size="0x100000" crc="0703b761" sha1="7d586b69bb9578d550871eda884cd6b32d86a01f" />
<rom name="202-v8.bin" offset="0x700000" size="0x100000" crc="8d525588" sha1="297871c1e8888d9adab3781fb6c2c27ecf50ca45" />
<rom name="202-v9.bin" offset="0x800000" size="0x100000" crc="97f073b6" sha1="02a4cce3f0cdb9421350ee5af49af13d7dcd16c2" />
</dataarea>
<dataarea name="sprites" size="0x4000000">
<rom loadflag="load16_byte" name="202-c1.bin" offset="0x000000" size="0x800000" crc="aa469494" sha1="fd98b7445c85174ccb745c74cb9e852b08353324" />
<rom loadflag="load16_byte" name="202-c2.bin" offset="0x000001" size="0x800000" crc="fa07ba1e" sha1="8c00be2c0c1402789011e2aa272e04e216fdac10" />
<rom loadflag="load16_byte" name="202-c3.bin" offset="0x1000000" size="0x800000" crc="aa469494" sha1="fd98b7445c85174ccb745c74cb9e852b08353324" />
<rom loadflag="load16_byte" name="202-c4.bin" offset="0x1000001" size="0x800000" crc="fa07ba1e" sha1="8c00be2c0c1402789011e2aa272e04e216fdac10" />
<rom loadflag="load16_byte" name="202-c5.bin" offset="0x2000000" size="0x800000" crc="aa469494" sha1="fd98b7445c85174ccb745c74cb9e852b08353324" />
<rom loadflag="load16_byte" name="202-c6.bin" offset="0x2000001" size="0x800000" crc="fa07ba1e" sha1="8c00be2c0c1402789011e2aa272e04e216fdac10" />
<rom loadflag="load16_byte" name="202-c7.bin" offset="0x3000000" size="0x800000" crc="aa469494" sha1="fd98b7445c85174ccb745c74cb9e852b08353324" />
<rom loadflag="load16_byte" name="202-c8.bin" offset="0x3000001" size="0x800000" crc="fa07ba1e" sha1="8c00be2c0c1402789011e2aa272e04e216fdac10" />
</dataarea>
</part>
</software>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’ve got mixed space and tab indentation here.

The offsets here don’t all have the same number of digits – there’s no point padding out small offsets 0x0 and 0x1 to arbitrary lengths if you aren’t going to align them within a data area anyway.

Also, this one has hex sizes while some of the others have decimal sizes juxtaposed with hex offsets. It’s probably better to just use hex for sizes as well as offsets so it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done some fixes.
Please check.

hash/neogeo.xml Outdated Show resolved Hide resolved
hash/neogeo.xml Outdated Show resolved Hide resolved
@cuavas
Copy link
Member

cuavas commented May 15, 2024

I'm also not sure if "unlicensed 3rd party" is the right descriptor here, since it's technically a homebrew, fan-developed game.

For systems with any kind of protection against running unlicensed software, “homebrew” is unlicensed third-party development, isn’t it? Also, unless it only uses original characters, artwork, sounds, source material, etc. or obtains a license from copyright holders, it’s also an unauthorised derivative work from a copyright perspective.

- Changed decimal size value to hex value
- Fixed indentation to tab char
- Fixed offsets
@cuavas cuavas merged commit 6eb246f into mamedev:master May 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants