ninjakd2.cpp: Updates and cleanups: #12385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cam900
commented
May 18, 2024
cam900
commented
- Fix robokid, omegaf palette format
- Fix function namings
- Fix spacings
- Reduce preprocessor defines
- Suppress side effect for debugger read
- Use C++ style comments for single line comments
- Use correct typename values
- Fix ROM region namings
- Constantize variables
- Reduce literal tag usage
- Fix robokid, omegaf palette format - Fix function namings - Fix spacings - Reduce preprocessor defines - Suppress side effect for debugger read - Use C++ style comments for single line comments - Use correct typename values - Fix ROM region namings - Constantize variables
…'t mix data members with member functions, etc.
cuavas
reviewed
May 18, 2024
src/mame/upl/ninjakd2_v.cpp
Outdated
Comment on lines
345
to
348
| if (!m_next_sprite_overdraw_enabled) | ||
| { | ||
| m_sprites_bitmap.fill(0xf); | ||
| } | ||
| else | ||
| { |
There was a problem hiding this comment.
Please don’t remove the braces from one path where all other paths have braces. It’s a common recommendation to use braced compound statements for all paths if at least one path contains multiple lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.