vsystem/fromanc2.cpp: Cleanups #12407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cam900
commented
May 25, 2024
cam900
commented
- Split driver state class for reduce optional finders
- Correct type for variables
- Use C++ style comments for single line comments
- Reduce literal tag usage and runtime tag lookups
- Suppress side effects for debugger read
- Use generic gfx decode layout
- Constantize variables
- Fix spacing
- Split driver state class for reduce optional finders - Correct type for variables - Use C++ style comments for single line comments - Reduce literal tag usage and runtime tag lookups - Suppress side effects for debugger read - Use generic gfx decode layout - Constantize variables - Fix spacing
cuavas
reviewed
May 25, 2024
src/mame/vsystem/fromanc2.cpp
Outdated
Comment on lines
57
to
68
| switch (m_portselect) | ||
| { | ||
| case 0x01: ret = ioport("KEY0")->read(); break; | ||
| case 0x02: ret = ioport("KEY1")->read(); break; | ||
| case 0x04: ret = ioport("KEY2")->read(); break; | ||
| case 0x08: ret = ioport("KEY3")->read(); break; | ||
| default: ret = 0xffff; | ||
| logerror("PC:%08X unknown %02X\n", m_maincpu->pc(), m_portselect); | ||
| case 0x01: ret = m_in_key[0]->read(); break; | ||
| case 0x02: ret = m_in_key[1]->read(); break; | ||
| case 0x04: ret = m_in_key[2]->read(); break; | ||
| case 0x08: ret = m_in_key[3]->read(); break; | ||
| default: | ||
| ret = 0xffff; | ||
| if (!machine().side_effects_disabled()) | ||
| logerror("PC:%08X unknown %02X\n", m_maincpu->pc(), m_portselect); | ||
| break; | ||
| } |
There was a problem hiding this comment.
This is a key matrix that the author failed to recognise. It’s better to emulate them properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.