Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seattle.cpp and vegas.cpp: Clean House (nw) #6543

Merged
merged 1 commit into from Apr 26, 2020

Conversation

Hydreigon223
Copy link
Contributor

All unnecessary inputs are removed from all respective games without problems. I decided to remove "IMPERFECT_SOUND" from the NBA Showtime games because those games used a standard Vegas SIO board.

@Hydreigon223
Copy link
Contributor Author

Also changed the monitor resolution dip switch setting to reflect factory defaults. warfa originally came shipped with a standard res monitor and roadburn with a VGA res monitor.

warfa manual: http://www.aurcade.com/games/manuals/00001302.pdf

roadburn manual: http://www.thebasementarcade.com/manuals/roadburners.pdf

@cuavas
Copy link
Member

cuavas commented Apr 21, 2020

We usually provide all inputs a board supports (e.g. shown in service mode), even if games don’t use them.

@Hydreigon223
Copy link
Contributor Author

Hydreigon223 commented Apr 22, 2020

Except most of these games don't show the unused inputs in service mode (Road Burners for example). Also look at naomi.cpp as game specific inputs for this driver end up removing most of the unused inputs. Would you think it's okay to leave unused inputs as is in hotd2? I personally think it isn't.

Other examples: model1.cpp, model2.cpp, namcos22.cpp

@tedgreen99 tedgreen99 merged commit 5f65526 into mamedev:master Apr 26, 2020
hackbar pushed a commit to hackbar/mame that referenced this pull request Apr 26, 2020
@Hydreigon223 Hydreigon223 deleted the svinputs branch June 27, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants