Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add init to convert twinbeeb bubble dump into something the driver can actually use (nw) #6646

Merged
merged 2 commits into from May 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 5, 2020

this is proof of the problem.. better would be to know why the dump was stripped in the first place...

ghost referenced this pull request May 5, 2020
----------------------------------
TwinBee (Bubble System) [Raki, Dumping Union]
@angelosa
Copy link
Member

angelosa commented May 5, 2020

imho it must be marked as bad_dump

@ghost
Copy link
Author

ghost commented May 5, 2020

fwiw I've also added the CRC for the reencoded data, although obviously I don't know if it's 100% accurate.

I'll leave it up to somebody else to decide the best course of action with this (including any BAD_DUMP marking) either way the game works if the data being fed is actually in the expected format, either with the reencode function I've added, or just by loading the reencoded data.

I do worry with BAD_DUMP marking we end up with some political mess with people not liking their work being marked as BAD and refusing to dump anything else, even if something is better than nothing with cases like this, however I don't know if that is likely to be the case here as I don't know those involved.

@Osso13
Copy link
Member

Osso13 commented May 5, 2020

I propose to wait for an answer from the DU, then the best course of action can be decided

@ghost
Copy link
Author

ghost commented May 8, 2020

I think until there's a solution this can probably be merged tho? if a new dump surfaces, the extra init gets deleted and the correct format image loaded. this is no worse than leaving it non-working.

@Osso13
Copy link
Member

Osso13 commented May 8, 2020

I agree, even though IMHO there's no rush since it won't be in 0.221 anyway. I'll merge and then we can revisit once we have more info available.
BTW, thanks for looking at this!

@Osso13 Osso13 merged commit c83d7fe into mamedev:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants