Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asmjit: new 3rdparty library #6756

Merged
merged 1 commit into from
May 30, 2020
Merged

asmjit: new 3rdparty library #6756

merged 1 commit into from
May 30, 2020

Conversation

pmackinlay
Copy link
Contributor

I propose adding this library to MAME.

The intent is to use it to replace the x86 and amd64 code emitter logic in the current and potential future MAME drc backend(s). The author of the library has plans (although no timeframe) to support ARM targets in the future, which would likely also be useful for a backend targeting those architectures.

In my opinion, it ticks the boxes in terms of zlib license, mostly tidy C++11 code, no external dependencies, active development, good feature set, Windows/OSX/Linux and MSVC/Clang/GCC support, and a seemingly sensible API.

I have made one change to the source code, uncommenting the definition of the ASMJIT_STATIC preprocessor variable in the api-config.h header; defining it in the build script appeared to be a better option, but caused linker warnings that I couldn't see how to resolve without polluting the rest of the build with the definition.

I have tested compiling and running a driver which uses the library under MSVC and GCC without observing any problems.

@rb6502
Copy link
Contributor

rb6502 commented May 29, 2020

I think this looks good - the code's reasonable, the license is good, and it's actively supported.

@rb6502 rb6502 merged commit 531b2fd into mamedev:master May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants