Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bosco.cpp: Sprites have a lower priority than BG. #6880

Merged
merged 2 commits into from Jun 29, 2020

Conversation

@kunikunijp
Copy link
Contributor

@kunikunijp kunikunijp commented Jun 29, 2020

Sprites have a lower priority than BG.

MAME 0.222
Link Text

Fixed
Link Text

PCB
Link Text

Sprites have a lower priority than BG.

PCB
![Link Text](https://i.imgur.com/AeW2eQd.gif "PCB")

MAME 0.222
![Link Text](https://i.imgur.com/tAqLpeP.gif "MAME 0.222")

Fixed
![Link Text](https://i.imgur.com/Qq6nSp9.gif "Fixed")
@happppp
Copy link
Member

@happppp happppp commented Jun 29, 2020

Ok, so it doesn't have high priority tilemap characters. Then these can be removed:

tileinfo.category = (attr & 0x20) >> 5;

/* draw the high priority characters */
m_bg_tilemap->draw(screen, bitmap, bg_clip, 1,0);
m_fg_tilemap->draw(screen, bitmap, fg_clip, 1,0);

and the last 2 parameters of the tilemap functions are obsolete now, so:

m_bg_tilemap->draw(screen, bitmap, bg_clip);
m_fg_tilemap->draw(screen, bitmap, fg_clip);
@kunikunijp
Copy link
Contributor Author

@kunikunijp kunikunijp commented Jun 29, 2020

Thank you for your advice.
However, the "flags" parameter of the tilemap function could not be omitted due to a build error.

m_bg_tilemap->draw(screen, bitmap, bg_clip, 0);
m_fg_tilemap->draw(screen, bitmap, fg_clip, 0);

@happppp
Copy link
Member

@happppp happppp commented Jun 29, 2020

Ah right, I thought it had a default param for the flags, maybe I can add that.

@happppp happppp merged commit e981845 into mamedev:master Jun 29, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kunikunijp kunikunijp deleted the kunikunijp:bosco-patch-1 branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.