Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seta2.cpp: Fix invisible pixel issue in horizontal zoom algorithm #7198

Merged
merged 1 commit into from
Sep 9, 2020
Merged

seta2.cpp: Fix invisible pixel issue in horizontal zoom algorithm #7198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mame/drivers/seta2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ P0-145-1 2002 Trophy Hunting - Bear & Moose (test) Sammy
- Fix some graphics imperfections (e.g. color depth selection, "tilemap" sprites) [all done? - NS]
- I added a kludge involving a -0x10 yoffset, this fixes the lifeline in myangel.
I didn't find a better way to do it without breaking pzlbowl's title screen.
- 1 rightmost pixel columns are not drawn when zoomed
- Background color is not verified

gundamex:
- slowdowns, music tempo is incorrect
Expand Down
6 changes: 3 additions & 3 deletions src/mame/video/seta2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ inline void seta2_state::drawgfx_line(bitmap_ind16& bitmap, const rectangle& cli
uint16_t* dest = &bitmap.pix16(screenline);

int minx = cliprect.min_x << 16;
int maxx = cliprect.max_x << 16;
int maxx = (cliprect.max_x + 1) << 16;

if (xzoom < 0x10000) // shrink
{
Expand All @@ -337,7 +337,7 @@ inline void seta2_state::drawgfx_line(bitmap_ind16& bitmap, const rectangle& cli
uint8_t pen = (source[column++] & gfx_mask) >> gfx_shift;


if (sx >= minx && sx <= maxx)
if (sx >= minx && sx < maxx)
{
int realsx = sx >> 16;

Expand Down Expand Up @@ -379,7 +379,7 @@ inline void seta2_state::drawgfx_line(bitmap_ind16& bitmap, const rectangle& cli
{
uint8_t pen = (source[column] & gfx_mask) >> gfx_shift;

if (sx >= minx && sx <= maxx)
if (sx >= minx && sx < maxx)
{
int realsx = sx >> 16;

Expand Down