Complete sound modernization of remaining devices. Legacy callbacks and stream_sample_t removed. #7297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…audio/arcadia/channelf/cmi01a/cps3/dai_snd: Update to new stream callbacks
…e to new stream callbacks
…date to new stream callbacks.
…x/gic: Update to new stream callback
* micro3d: Remove tiny vectors in favor of fixed arrays * phoenix: Went back to std::unique_ptr array for LFSR
cuavas
reviewed
Sep 28, 2020
| @@ -101,7 +101,6 @@ void phoenix_sound_device::device_start() | |||
| save_item(NAME(m_noise_state.polyoffs)); | |||
| save_item(NAME(m_noise_state.lowpass_counter)); | |||
| save_item(NAME(m_noise_state.lowpass_polybit)); | |||
| save_pointer(NAME(m_poly18), (1ul << (18-5))); | |||
There was a problem hiding this comment.
The reasoning for this being saved was probably so you can see/hack it in debugger memory views. Not sure if anyone actually used it.
|
May as well merge this now and catch whatever breaks early. |
ksherlock
pushed a commit
to ksherlock/mame
that referenced
this pull request
Sep 30, 2020
…nd stream_sample_t removed. (mamedev#7297) * a2mcms/coco_ssc/gus/cassette/floppy/8364_paula/laserdsc/s2636/spg2xx_audio/arcadia/channelf/cmi01a/cps3/dai_snd: Update to new stream callbacks * dsbz80/elan_eu3a05/exidy/exidy440/flower/geebee/gomoku/gridlee: Update to new stream callbacks * hyprolyb/lynx/micro3d/phoenix/pleiads/polepos: Update to new sound stream callback * redbaron/segag80r/segausb/seibu/snk6502/socrates/special/svis_snd: Update to new stream callbacks. * tiamc1/turrett/tvc/tx1/vboy/vc4000: Update to new stream callbacks * warpwarp/wiping/wswan/xavix/esq1/istrebiteli/milton6805/pv1000/mega32x/gic: Update to new stream callback * sound: Remove legacy stream support and stream_sample_t * * gomoku/wiping: Remove silly mixer tables in favor of math * micro3d: Remove tiny vectors in favor of fixed arrays * phoenix: Went back to std::unique_ptr array for LFSR * wiping: Fixed the scale factor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.