Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my suggestions to brdrline trigger assignments #7332

Merged
merged 4 commits into from Oct 6, 2020
Merged

my suggestions to brdrline trigger assignments #7332

merged 4 commits into from Oct 6, 2020

Conversation

beta-tester
Copy link
Contributor

according to #7328 and #7091 i would change the triggers for the inputs a little bit to fit the sounds more to what i remember to.
its only suggestions.

- cleaned some parts of nl_brdrline.cpp (removed test points)
- changed MB4391 function to pow2 to shorten sounds a bit
- changed trigger inputs in vicdual.cpp to fit more to the sounds i remember.
to be in line with changed nl_brdrline.cpp
forgot to remove my temporary change
src/mame/audio/nl_brdrline.cpp Show resolved Hide resolved
src/mame/audio/nl_brdrline.cpp Show resolved Hide resolved
src/mame/audio/vicdual.cpp Show resolved Hide resolved
@ghost
Copy link

ghost commented Oct 6, 2020

somebody is reporting there should be a startup melody, and that it was present in an old sample set. are they misremembering, or is something like that still missing?

@beta-tester
Copy link
Contributor Author

@aaronsgiles ,

  1. i moved the trigger input mapping from vicdual to nl_brdrline file.
  2. i used the mapping from the schematics as you showed me. i didn't realized this part of the schematics (some parts are hard to read because of the low resolution).
    but i am still confused - in my head i have an other mapping, so i added my suggested mapping as alternative (#if #else).
  3. i included your suggestion to lower the freq for the noise gen. (i hope it is included correctly there)

@davidhaywood , i can't remember if there was a melody when inserting a coin. in the schematics i can not see any hint of that. maybe it was an extra sound board directly connected to the coin mechanisim.

from my memory i have also a slightly different sound in my head for crawling through the field in section 2 & 3. the ANIMAL_SOUND is close to that but not 100% right what i have in mind.

i double checked the netlist but can't find an error in it.
maybe i was playing a modified version of the arcade Borderline in the early 1980'th or my head remembers to things that are not real...

@aaronsgiles aaronsgiles merged commit 288ca11 into mamedev:master Oct 6, 2020
@vidpro1
Copy link

vidpro1 commented Oct 26, 2020

There is a start melody when you power on the pcb. The same melody plays when you start a game. There is a coin/credit sound that is separate. I can help out on this after I get a working build of the netlist version. It looks someone was trying to sort out the Tranquilizer Gun sample names from a long time ago (There was a conversion kit from Tranquilizer gun to Borderline) Not sure what that sound Borderline sound board looks like but it can't be the same as Tranqgun. There is a Sega Saturn version of Borderline but I'm pretty sure the sound emulation is wrong on that one.

Sample names if you haven't used them already for netlist conversions.

boot_and_start
coin
crashes
end_level
enginenoise
field
fire

@ghost
Copy link

ghost commented Oct 26, 2020

so what you're saying if we haven't emulated the borderline sound board at all? only the one used for the tranqulilzer gun conversion (where we don't even have a complete dump of the romset as one ROM was bad on the PCB it was dumped from)

@Osso13
Copy link
Member

Osso13 commented Oct 26, 2020

AFAIK he's referring to samples Corrado recorded from a Borderline bootleg board, which might be a direct clone of the original or not, who knows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants