cyclemb.cpp: Remove MACHINE_IMPERFECT_SOUND flags #8055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think Cycle Maaboh sounds was corrected on pull request for #7979. And, Sky Destroyer does not seem to have any sound imperfections compared to PCB. So I want to remove the MACHINE_IMPERFECT_SOUND flag from the driver. (If you think I should not remove the flag, please review it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think Cycle Maaboh sounds was corrected on pull request for #7979.
And, Sky Destroyer does not seem to have any sound imperfections compared to PCB.
So I want to remove MACHINE_IMPERFECT_SOUND flags from the driver.
(If you think I should not remove the flag, please review it)