Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed j6bigbuk Exchange Number button port name and in layout #8343

Merged
merged 1 commit into from Jan 15, 2022

Conversation

TheBoyCanFly
Copy link
Contributor

No description provided.

Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Exchange button on J9_2:0x02 actually used, and should it be added to the layout, or is it not present at all?

@TheBoyCanFly
Copy link
Contributor Author

@cuavas I'm unsure what the switches in J9_2 are for but they are not gameplay buttons. The layout mistakenly used J9_2 instead of J10_2.

@cuavas
Copy link
Member

cuavas commented Jul 25, 2021

The way it is now, it could be misleading, perhaps J9_2:0x02 should have its label changed? @james-wallace-ghub can you comment?

@TheBoyCanFly
Copy link
Contributor Author

@cuavas Misleading in what way? All that's changed is that Exchange Number has been moved to the correct hardware button rather than sharing Nudge 3 which was wrong. I didn't want to remove the J9_2 portmap because it could well be used for something else that I'm unaware of.

@cuavas
Copy link
Member

cuavas commented Jul 26, 2021

There’s now a button called “Exchange” and another called “Exchange Number” in the inputs for the machine. You’re saying that the “Exchange” button isn’t a gameplay button. That could be misleading or confusing.

@TheBoyCanFly
Copy link
Contributor Author

Aha! I see where the confusion lies. These are two gameplay buttons, Exchange (along the bottom panel), and Exchange Number (on the top panel). I'm saying J9_2 that was used for Exchange Number was incorrect, it should have been J10_2

@Robbbert Robbbert merged commit 93b3d4b into mamedev:master Jan 15, 2022
@james-wallace-ghub
Copy link
Member

I see you've merged, but yes, this is correct - with two separate 'Exchange' options in test mode, they clearly got muddled.

Exchange often means "Exchange current win for position in feature".
Exchange number often means 'swap number on hi/lo'. Barcrest often use "SWOP" (sic) for this one, which is less of a headache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants