jpmsru: Added Lucky Casino #9864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SomeRandomGuyIdk
commented
May 30, 2022
SomeRandomGuyIdk
commented
- Added a new game, Lucky Casino
- Added 50p slot and lockout to Super 2
cuavas
reviewed
May 30, 2022
src/mame/drivers/jpmsru.cpp
Outdated
Comment on lines
1058
to
1059
| PORT_BIT( 0x02, IP_ACTIVE_HIGH, IPT_BUTTON1 ) PORT_NAME("Take Win") | ||
| PORT_BIT( 0x04, IP_ACTIVE_HIGH, IPT_BUTTON2 ) PORT_NAME("Take Half") |
There was a problem hiding this comment.
There are IPT_GAMBLE_TAKE and IPT_GAMBLE_HALF types for these.
src/mame/mame.lst
Outdated
Comment on lines
19153
to
19157
| j_goldn2 // Golden 2's (CTL) | ||
| j_sup2p // Super 2p Shuffle (MDM) | ||
| j_la // Lucky Aces | ||
| j_lc // Lucky Casino (JPM) | ||
| j_lca // |
There was a problem hiding this comment.
Please sort these by short name within the section for the file. It makes it easier to find things.
cuavas
reviewed
Jun 6, 2022
src/mame/drivers/jpmsru.cpp
Outdated
Comment on lines
502
to
507
| case 2: m_logicext_addr = (m_logicext_addr & ~0x01) | (data ? 0x00 : 0x01); break; | ||
| case 3: m_logicext_addr = (m_logicext_addr & ~0x02) | (data ? 0x00 : 0x02); break; | ||
| case 4: m_logicext_addr = (m_logicext_addr & ~0x04) | (data ? 0x00 : 0x04); break; | ||
| case 5: m_logicext_addr = (m_logicext_addr & ~0x08) | (data ? 0x00 : 0x08); break; | ||
| case 6: m_logicext_addr = (m_logicext_addr & ~0x10) | (data ? 0x00 : 0x10); break; | ||
| case 7: m_logicext_addr = (m_logicext_addr & ~0x20) | (data ? 0x00 : 0x20); break; |
There was a problem hiding this comment.
Could you consolidate these cases to something like m_logicext_addr = (m_logicext_addr & ~(1 << (offset - 2))) | (data ? 0 : (1 << (offset - 2)))? Right now there are a pile of almost duplicated lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.