Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance moving operation from nameFolder to idFolder #1739

Merged
merged 4 commits into from
Dec 18, 2021
Merged

enhance moving operation from nameFolder to idFolder #1739

merged 4 commits into from
Dec 18, 2021

Conversation

Nambers
Copy link
Contributor

@Nambers Nambers commented Dec 15, 2021

#1738
#1737
origin pr: mirai-console#418

  • fix autoSaveData
  • moving config folder
  • console tests
  • check plugin name usage

@Him188 Him188 added this to the 2.9.0-RC2 milestone Dec 15, 2021
@Him188 Him188 added s:console 子系统: mirai-console M 优先级: 主要 t:bug 类型: bug labels Dec 15, 2021
@Karlatemp
Copy link
Member

and config/ ?

@Nambers
Copy link
Contributor Author

Nambers commented Dec 15, 2021

and config/ ?

configFolder好像还没做移动到idFolder, 需要在这个pr里一起做了吗

@Karlatemp
Copy link
Member

我将会起草 console 的 real-time test-unit, 请等 test-unit 完善后继续修改 pr

@Karlatemp
Copy link
Member

Please add(or modify) a test unit after #1741 meged

@Him188
Copy link
Member

Him188 commented Dec 15, 2021

and config/ ?

configFolder好像还没做移动到idFolder, 需要在这个pr里一起做了吗

可以, 把 commits 分开, 写两个 commits, 我用 rebase merge

@Nambers Nambers changed the title Fix new nameFolder after moving enhance moving operation from nameFolder to idFolder Dec 16, 2021
@Karlatemp Karlatemp self-assigned this Dec 18, 2021
@Karlatemp Karlatemp merged commit 1d1a77f into mamoe:dev Dec 18, 2021
@github-pages github-pages bot temporarily deployed to github-pages December 18, 2021 17:14 Inactive
@Nambers Nambers deleted the fixMoving branch December 19, 2021 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M 优先级: 主要 s:console 子系统: mirai-console t:bug 类型: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.9.0-RC 数据目录无法自动迁移,且删除后重启依旧 2.9.0-RC插件数据目录迁移有残留
3 participants