Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.9.0-RC插件数据目录迁移有残留 #1737

Closed
Samarium150 opened this issue Dec 13, 2021 · 5 comments · Fixed by #1739
Closed

2.9.0-RC插件数据目录迁移有残留 #1737

Samarium150 opened this issue Dec 13, 2021 · 5 comments · Fixed by #1739
Labels
M 优先级: 主要 s:console 子系统: mirai-console t:bug 类型: bug
Milestone
2.9.0-RC2

Comments

@Samarium150
Copy link
Contributor 

2021-12-13 21:32:56 I/JvmPluginLoader: 移动 Lolicon v5.0.0-beta.2 的配置目录(**\mirai-console-lolicon\run\data\Lolicon)到 **\mirai-console-lolicon\run\data\io.github.samarium150.mirai.plugin.mirai-console-lolicon
2021-12-13 21:32:56 I/JvmPluginLoader: 移动 Lolicon v5.0.0-beta.2 的配置目录(**\mirai-console-lolicon\run\data\Lolicon)到 **\mirai-console-lolicon\run\data\io.github.samarium150.mirai.plugin.mirai-console-lolicon 完成
2021-12-13 21:32:56 I/Lolicon: Plugin loaded

数据目录迁移成功了，但原来目录以及yaml文件还留着
左图为迁移前，右图为迁移后
beforeafter

以及为什么配置文件目录不也改用id作为文件夹名呢
@Him188 Him188 transferred this issue from mamoe/mirai-console Dec 13, 2021
@Him188 Him188 added t:bug 类型: bug s:console 子系统: mirai-console M 优先级: 主要 labels Dec 13, 2021
@Him188 Him188 added this to the 2.9.0 milestone Dec 13, 2021
@Him188
Copy link
Member

Him188 commented Dec 13, 2021

删除文件可能比较危险，因此没有做

@LaoLittle
Copy link
Contributor

想知道是不是为了防止中文文件夹

@Samarium150
Copy link
Contributor Author

想知道是不是为了防止中文文件夹

mamoe/mirai-console#276

@Samarium150 Samarium150 mentioned this issue Dec 14, 2021
Closed
@Nambers
Copy link
Contributor

Nambers commented Dec 14, 2021 

2021-12-13 21:32:56 I/JvmPluginLoader: 移动 Lolicon v5.0.0-beta.2 的配置目录(**\mirai-console-lolicon\run\data\Lolicon)到 **\mirai-console-lolicon\run\data\io.github.samarium150.mirai.plugin.mirai-console-lolicon
2021-12-13 21:32:56 I/JvmPluginLoader: 移动 Lolicon v5.0.0-beta.2 的配置目录(**\mirai-console-lolicon\run\data\Lolicon)到 **\mirai-console-lolicon\run\data\io.github.samarium150.mirai.plugin.mirai-console-lolicon 完成
2021-12-13 21:32:56 I/Lolicon: Plugin loaded

数据目录迁移成功了，但原来目录以及yaml文件还留着 左图为迁移前，右图为迁移后 beforeafter

以及为什么配置文件目录不也改用id作为文件夹名呢

我本地mcl看好像没什么问题(
在pr里也是直接rename的https://github.com/mamoe/mirai-console/pull/418/files#diff-1acbc1cabfaa439a4693a654460aa8d2890edd3c718df1c9a6e7129c9e85c178R130

@Nambers Nambers mentioned this issue Dec 15, 2021
Merged
4 tasks
@Him188 Him188 linked a pull request Dec 15, 2021 that will close this issue
enhance moving operation from nameFolder to idFolder #1739
Merged
4 tasks
@Him188 Him188 modified the milestones: 2.9.0, 2.9.0-RC2 Dec 15, 2021
@SekiBetu
Copy link

删除文件可能比较危险，因此没有做

换个思路，不是删除，而是文件夹改名

@Samarium150 Samarium150 mentioned this issue Dec 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
M 优先级: 主要 s:console 子系统: mirai-console t:bug 类型: bug
Projects
None yet
Milestone
2.9.0-RC2
Development

Successfully merging a pull request may close this issue.

enhance moving operation from nameFolder to idFolder
5 participants
@Him188 @Samarium150 @Nambers @SekiBetu @LaoLittle