-
Notifications
You must be signed in to change notification settings - Fork 93
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extract include_deleted out of LoadType and allow full cartesian product
Introduces a new type LoadStrategy which has the load_type, the to_load enum, which indicates whether to load ANY or only UNDELETED versions and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain and FollowingVersionChainWithCaching cpp tests
- Loading branch information
Showing
12 changed files
with
423 additions
and
251 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.