Link against python explicitly in order to make MSVS builds work #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexowens90
approved these changes
Jan 2, 2024
vasil-pashov
force-pushed
the
dev/vasil.pashov/fix-msvs-builds
branch
from
4ba4e33
to
38e4531
Compare
vasil-pashov
force-pushed
the
dev/vasil.pashov/fix-msvs-builds
branch
from
38e4531
to
bef81bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
MSVS builds fail because they can't find python. We get Python as transitive dependency via pybind11, however debug MSVS builds (by default) require all dependencies to be build in debug and pybind11's python is in release. Thus adding explicit linkage will use the library found via find_package.
Any other comments?
Debug python symbols can be installed via python installer.
While having debug python is nice the binary becomes huge and it takes quite a lot of time to load the DLL. In future we should add option to work with release python in MSVS.
Checklist
Checklist for code changes...